Re: [Outreachy kernel] [PATCH v4 1/2] Staging: speakup: Add helper macro for spk_synth boilerplate

[Greg KH <gregkh@linuxfoundation.org>]

On Tue, Mar 17, 2015 at 04:06:23PM +0530, Vaishali Thakkar wrote:
> For simple modules that contain a single spk_synth without
> any additional setup code then ends up being a block of
> duplicated boilerplate. This patch adds a new macro,
> module_spk_synth(), which replaces the
> module_init()/module_exit() registrations with template
> functions.
> 
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
> Changes since v1:
>         - Use module_driver macro in definition of helper macro
> Changes since v2:
>         - Correct unnecessory line wrapping of module_driver
>         - Split patch in to 2 patches
> Changes since v3:
> 	- Put blank line after module_spk_synth
> 
>  drivers/staging/speakup/spk_types.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/staging/speakup/spk_types.h b/drivers/staging/speakup/spk_types.h
> index 8c565c9..38e0a3c 100644
> --- a/drivers/staging/speakup/spk_types.h
> +++ b/drivers/staging/speakup/spk_types.h
> @@ -16,6 +16,7 @@
>  #include <linux/spinlock.h>
>  #include <linux/mutex.h>
>  #include <linux/io.h>		/* for inb_p, outb_p, inb, outb, etc... */
> +#include <linux/device.h>	/* for struct device */

Ah, more complaints sorry...

You aren't including this for 'struct device' you are doing it for
module_driver().  Just remove the /* */ entirely, you don't need to
specify why you are including a .h file, that's not needed.

thanks,

greg k-h