From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932537AbbCQOLj (ORCPT ); Tue, 17 Mar 2015 10:11:39 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:49923 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932138AbbCQOLh (ORCPT ); Tue, 17 Mar 2015 10:11:37 -0400 Date: Tue, 17 Mar 2015 15:11:18 +0100 From: Peter Zijlstra To: Jiri Olsa Cc: Vince Weaver , linux-kernel@vger.kernel.org, Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo Subject: Re: perf: fuzzer causes lockup in x86_pmu_event_init() Message-ID: <20150317141118.GD23123@twins.programming.kicks-ass.net> References: <20150225151639.GL5029@twins.programming.kicks-ass.net> <20150228121442.GA1653@krava> <20150317135536.GA14587@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150317135536.GA14587@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 17, 2015 at 02:55:36PM +0100, Jiri Olsa wrote: > On Mon, Mar 02, 2015 at 02:13:25PM -0500, Vince Weaver wrote: > > On Sat, 28 Feb 2015, Jiri Olsa wrote: > > > > > hum, I dont see the locking is a problem.. but looks like once > > > the sibling becomes singleton event, we dont init its sibling_list > > > > > > how about patch below.. compile tested ;-) > > > > so this is instead of PeterZ's patch? > > > > I'll start my test-machine fuzzing with this plus the infinite-interrupt > > fix and see what happens. The machines do eventually trigger the issue > > somwhat consistently but it can take up to a week before they hit it > > so it's a tough one to test for. > > I guess no news is good news in here.. ;-) > > Peter, should I repost formal patch or you'll take it somehow Yeah, please send with a proper changelog, I'll stuff it in someplace.