All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@codemonkey.org.uk>
To: tyson.w.smith@gmail.com
Cc: trinity@vger.kernel.org, tysmith@motorola.com
Subject: Re: [PATCH 7/7] strip down get_len() to a call to rand32()
Date: Tue, 17 Mar 2015 10:38:35 -0400	[thread overview]
Message-ID: <20150317143835.GC17556@codemonkey.org.uk> (raw)
In-Reply-To: <1426537627-55047-1-git-send-email-tyson.w.smith@gmail.com>

On Mon, Mar 16, 2015 at 01:27:07PM -0700, tyson.w.smith@gmail.com wrote:
 > From: Tyson Smith <tyson.w.smith@gmail.com>
 > 
 > The body of get_len() was the same as rand32() so applying it to a value
 > from rand32() didn't offer much value. A switch case could be
 > added that generates other length like values as well. This could include
 > 2^n +/- ~2, page_size +/- 1, MAX_INT... etc.

Makes sense, but we could go a step further, and just remove random-length.c
entirely, and have generate-args.c just do the rand32 call.
(same for the 2-3 syscalls that call it)

	Dave

      reply	other threads:[~2015-03-17 14:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 20:27 [PATCH 7/7] strip down get_len() to a call to rand32() tyson.w.smith
2015-03-17 14:38 ` Dave Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150317143835.GC17556@codemonkey.org.uk \
    --to=davej@codemonkey.org.uk \
    --cc=trinity@vger.kernel.org \
    --cc=tysmith@motorola.com \
    --cc=tyson.w.smith@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.