Re: [PATCH v3 2/2] i2c: Support for Netlogic XLP9XX/5XX I2C controller.

["Uwe Kleine-König" <u.kleine-koenig-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>]

Hello,

On Tue, Mar 17, 2015 at 08:00:40PM +0530, Jayachandran C. wrote:
> On Sat, Mar 14, 2015 at 09:01:24PM +0100, Uwe Kleine-König wrote:
> > On Sat, Mar 14, 2015 at 05:18:37PM +0530, Jayachandran C. wrote:
> > > On Fri, Mar 13, 2015 at 11:24:06AM +0100, Uwe Kleine-König wrote:
> > > > On Fri, Mar 13, 2015 at 11:59:58AM +0530, Jayachandran C wrote:
> > > > > diff --git a/drivers/i2c/busses/i2c-xlp9xx.c b/drivers/i2c/busses/i2c-xlp9xx.c
> > > > > new file mode 100644
> > > > > index 00000000..2f303ad
> > > > > --- /dev/null
> > > > > +++ b/drivers/i2c/busses/i2c-xlp9xx.c
> > > > > @@ -0,0 +1,446 @@
> > > > > [...]
> > > > > +
> > > > > +/*
> > > > > + * see Documentation/devicetree/bindings/i2c/i2c-xlp9xx.txt for device
> > > > > + * tree bindings documentation
> > > > > + */
> > > > When I asked for documentation here, I didn't meant the device tree
> > > > binding, but the hardware reference manual.
> > > 
> > > Unfortunately there is no standalone documentation for the I2C controller,
> > > this block is used in XLP9xx and XLP5xx SoCs and you can get the documentation
> > > for the whole SoC from support.broadcom.com if you have an account there.
> > I don't. According to the instructions to get such an account I have to
> > contact my "Sales/Engineering contacts at Broadcom or its
> > Distributors/Manufacturer's representatives directly". Who would that be
> > for me? You?
> 
> Not really. If you want to develop drivers for a XLP9xx board you
> have, then you should have an account at support site and the
> instructions apply.
I don't want to develop drivers for such a board, among other reasons
because I don't own one. But I want to make a review of such a driver.
And therefor a datasheet would be helpful.
 
> The rationale given in device tree guidelines is that the silicon vendor
> may release future chips which break the wildcard. In this specific case
> that issue will not happen, because the driver is from the silicon vendor.
> Anyway, for consistency, we will take out the wildcard in v4.
I honestly hope the high trust in your employer is justified. It didn't
work for me (for a different employer of course).

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |