All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: wad@chromium.org, msb@chromium.org, mpatocka@redhat.com
Subject: Re: [PATCH] dm-verity: Add error handling modes for corrupted blocks
Date: Tue, 17 Mar 2015 14:03:58 -0400	[thread overview]
Message-ID: <20150317180358.GD24901@redhat.com> (raw)
In-Reply-To: <20150317160649.GA36193@google.com>

On Tue, Mar 17, 2015 at 04:06:49PM +0000, Sami Tolvanen wrote:
> On Tue, Mar 17, 2015 at 11:27:49AM -0400, Vivek Goyal wrote:
> > What's the idea behind kernel restart mode ? If a corrupted block is in
> > the path of boot, will we not get into a continuous reboot cycle.
> 
> It depends on how dm-verity is used. If we have PSTORE_CONSOLE enabled, for
> example, after a restart we can check if the restart was caused by dm-verity
> and then use a different mode when setting up the verity device. Most likely
> for some systems this is not a reasonable recovery method, but we find it to
> be useful on Android at least.

Ok.

Without knowing too much of detail, asking kernel to restart because one
block was corrupt sounds little drastic. If you are sending user space
events, why not let user space initiate the start and manage policy in
user space.

Thanks
Vivek

  reply	other threads:[~2015-03-17 18:03 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 15:55 [PATCH] dm-verity: Add error handling modes for corrupted blocks Sami Tolvanen
2015-03-16 22:13 ` Will Drewry
2015-03-17  0:45   ` Alasdair G Kergon
2015-03-17 10:35     ` Sami Tolvanen
2015-03-17 10:23   ` Sami Tolvanen
2015-03-17  0:37 ` Alasdair G Kergon
2015-03-17 10:36   ` Sami Tolvanen
2015-03-17 15:27 ` Vivek Goyal
2015-03-17 16:06   ` Sami Tolvanen
2015-03-17 18:03     ` Vivek Goyal [this message]
2015-03-18 13:24       ` Sami Tolvanen
2015-03-18 15:42         ` Mikulas Patocka
2015-03-18 15:49           ` Sami Tolvanen
2015-03-17 16:37 ` [PATCHv2] " Sami Tolvanen
2015-03-17 18:50   ` Alasdair G Kergon
2015-03-18 13:26     ` Sami Tolvanen
2015-03-18 15:52 ` [PATCHv3] " Sami Tolvanen
2015-03-19 22:18   ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150317180358.GD24901@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=mpatocka@redhat.com \
    --cc=msb@chromium.org \
    --cc=wad@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.