From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] collectd: fix postgresql library detection
Date: Tue, 17 Mar 2015 22:58:08 +0100 [thread overview]
Message-ID: <20150317225808.3c2af021@free-electrons.com> (raw)
In-Reply-To: <1426628645-26181-1-git-send-email-ps.report@gmx.net>
Dear Peter Seiderer,
On Tue, 17 Mar 2015 22:44:05 +0100, Peter Seiderer wrote:
> ifeq ($(BR2_PACKAGE_POSTGRESQL),y)
> COLLECTD_CONF_OPTS += --with-libpq=$(STAGING_DIR)/usr/bin/pg_config
> + COLLECTD_CONF_ENV = LIBS="-lpthread -lm"
If they are needed, why isn't pg_config returning those linker flags?
I'm sorry to be annoying, but I really don't like adding LIBS variables
all over the place, because they tend to become wrong/unneeded, and we
never notice.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-17 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 21:44 [Buildroot] [PATCH v1] collectd: fix postgresql library detection Peter Seiderer
2015-03-17 21:58 ` Thomas Petazzoni [this message]
2015-03-17 22:17 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150317225808.3c2af021@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.