All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Shawn Embedded <programassem@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: Support two wm8962 codec in i.mx6 board.
Date: Tue, 17 Mar 2015 18:33:01 -0700	[thread overview]
Message-ID: <20150318013301.GA6432@Asurada-GSX> (raw)
In-Reply-To: <CAOaGyfUk6LLkZhLXpLVE_akGTD3Ekk0TX_u1Gzw5y3oidBMQOg@mail.gmail.com>

On Wed, Mar 18, 2015 at 09:12:19AM +0800, Shawn Embedded wrote:

>    Yes, it's and old version, without support of device tree.
>    For AUDMUX configuration, is the code below enough, snippet 1 and 2?

I think so.

>     And here I have another question about clock source sharing
> between the two codecs.
>     The two wm8962 codecs use the same clock source from imx6, in my
> case, clko, as the code mentioned below,

> Since the two codecs share the same clock source, clko, and we donot
> know when mxc_wm8962_init() and wm8962_clk_enable() will be called by
> using the function pointer exactly, do you think it's necessary to
> make NULL to init, make wm8962_clk_enable_do_nothing to clock_enable,
> and manually calling mxc_wm8962_init() and wm8962_clk_enable() in the
> xxx_board_init() function instead?

I don't think you need to change this part.

> 2. In imx-wm8962.c:
> 
> static int __devinit imx_wm8962_probe(struct platform_device *pdev)
> {
>     ....
>     imx_audmux_config(src, ext);    // should keep the same, not need
> to change, right?
>     ....
> }

No, you don't need to.
 
>   But there is a question here.
>   How should I track the  card_priv and its copy for the two codecs repectively.
>   They are used heavily.
>    In order to make the functions run without problems, seems
> necessary to differentiate the function call is for which codec of the
> two, right?
>   The same situation may exist for other just copied global variables
> in imx-wm8962.c.

Each dai-link will create an individual sound card during system
boot-up. Use 'aplay -l', you will see they are different devices.

  reply	other threads:[~2015-03-18  1:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16  7:30 Support two wm8962 codec in i.mx6 board Shawn Embedded
2015-03-17  0:55 ` Nicolin Chen
2015-03-17  1:51   ` Shawn Embedded
2015-03-17 18:00     ` Nicolin Chen
2015-03-18  1:12       ` Shawn Embedded
2015-03-18  1:33         ` Nicolin Chen [this message]
2015-03-18  4:48           ` Shawn Embedded
2015-03-18  4:58             ` Nicolin Chen
2015-03-18  5:10               ` Shawn Embedded

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150318013301.GA6432@Asurada-GSX \
    --to=nicoleotsuka@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=programassem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.