All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Vaishali Thakkar <vthakkar1994@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v3 2/2] Staging: speakup: Use module_spk_synth
Date: Wed, 18 Mar 2015 11:02:50 +0100	[thread overview]
Message-ID: <20150318100250.GA20143@kroah.com> (raw)
In-Reply-To: <767a3b6bf7c8776e57c6a11caa1d30bcedb265be.1426601963.git.vthakkar1994@gmail.com>

On Tue, Mar 17, 2015 at 07:57:39PM +0530, Vaishali Thakkar wrote:
> Macro module_spk_synth can be used for speakup drivers
> whose init and exit paths does only module registrations.
> So, here remove some boilerplate code by using
> module_spk_synth.
> 
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
> Changes since v1:
>         - No change but as patch is in series with
>           another patch, send new version.
> Changes since v2:
> 	- No change but as patch is in series with
>           another patch, send new version.

You didn't test build these changes :(

PLEASE always test your patches before sending them out, this series
broke the build horribly, and should have been very obvious that it
should have not been sent out.

greg k-h


  reply	other threads:[~2015-03-18 10:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 14:27 [PATCH v3 0/2] Staging: speakup: Introduce helper macro module_spk_synth Vaishali Thakkar
2015-03-17 14:27 ` [PATCH v5 1/2] Staging: speakup: Add helper macro for spk_synth boilerplate Vaishali Thakkar
2015-03-17 14:27 ` [PATCH v3 2/2] Staging: speakup: Use module_spk_synth Vaishali Thakkar
2015-03-18 10:02   ` Greg KH [this message]
2015-03-18 10:16     ` [Outreachy kernel] " Vaishali Thakkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150318100250.GA20143@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=vthakkar1994@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.