All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: netfilter-devel@vger.kernel.org, kaber@trash.net
Subject: Re: [nft PATCH] rule: delete extra space in rule indentation
Date: Wed, 18 Mar 2015 11:10:27 +0100	[thread overview]
Message-ID: <20150318101027.GA18800@salvia> (raw)
In-Reply-To: <20150317212327.20080.81689.stgit@nfdev.cica.es>

On Tue, Mar 17, 2015 at 10:23:27PM +0100, Arturo Borrero Gonzalez wrote:
> Annoying extra space in rule indentation.

What "extra space" are you refering to?

Could you include a small proof of it in the description? Thanks.

> Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
> ---
>  src/rule.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/rule.c b/src/rule.c
> index 8d76fd0..9403c1e 100644
> --- a/src/rule.c
> +++ b/src/rule.c
> @@ -237,11 +237,11 @@ void rule_print(const struct rule *rule)
>  	const struct stmt *stmt;
>  
>  	list_for_each_entry(stmt, &rule->stmts, list) {
> -		printf(" ");
>  		stmt->ops->print(stmt);
> +		printf(" ");
>  	}
>  	if (handle_output > 0)
> -		printf(" # handle %" PRIu64, rule->handle.handle);
> +		printf("# handle %" PRIu64, rule->handle.handle);
>  }
>  
>  struct scope *scope_init(struct scope *scope, const struct scope *parent)
> 

      reply	other threads:[~2015-03-18 10:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 21:23 [nft PATCH] rule: delete extra space in rule indentation Arturo Borrero Gonzalez
2015-03-18 10:10 ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150318101027.GA18800@salvia \
    --to=pablo@netfilter.org \
    --cc=arturo.borrero.glez@gmail.com \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.