Re: [Outreachy kernel] [PATCH v2] staging: p80211conv: Replace memcpy with ether_addr_copy

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Mar 18, 2015 at 01:10:58AM +0200, Ioana Ciornei wrote:
> Replace memcpy() with ether_addr_copy() since addresses are __aligned(2).
> The 2 structures are aligned to u16:
> 
> struct p80211_hdr_a3 {
> 	__le16 fc;		/* 0	2 */
> 	u16 dur;		/* 2	2 */
> 	u8 a1[ETH_ALEN];	/* 4	6 */	
> 	u8 a2[ETH_ALEN];	/* 10	6 */
> 	u8 a3[ETH_ALEN];	/* 16	6 */
> 	u16 seq;		/* 22	2 */
> } __packed;
> 
> Total size: 24
> 
> struct wlan_ethhdr {
> 	u8 daddr[WLAN_ETHADDR_LEN];	/* 0	6 */
> 	u8 saddr[WLAN_ETHADDR_LEN];	/* 6	6 */
> 	u16 type;			/* 12	2 */
> } __packed;
> 
> Total size: 14
> 
> Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
> ---
> 
> Changes in v2:
> 	- added explanations on why the addresses are aligned
> 
>  drivers/staging/wlan-ng/p80211conv.c | 21 +++++++++++----------
>  1 file changed, 11 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
> index bd69e8c..a51fbfe 100644
> --- a/drivers/staging/wlan-ng/p80211conv.c
> +++ b/drivers/staging/wlan-ng/p80211conv.c
> @@ -62,6 +62,7 @@
>  #include <linux/etherdevice.h>
>  #include <linux/if_ether.h>
>  #include <linux/byteorder/generic.h>
> 
>  #include <asm/byteorder.h>
>  
> @@ -178,21 +179,21 @@ int skb_ether_to_p80211(wlandevice_t *wlandev, u32 ethconv,

This patch is corrupted, it looks like you edited it by hand, which is
fine if you know the format, but when you don't, it breaks the tool and
can not be applied.

Look at that hunk above, it doesn't do anything, which is a hint that
something bad went wrong :(

Please fix up and resend.

thanks,

greg k-h