From: Dan Carpenter <dan.carpenter@oracle.com>
To: vinod.koul@intel.com
Cc: alsa-devel@alsa-project.org
Subject: Re: ASoC: Intel: mrfld- add ACPI module
Date: Wed, 18 Mar 2015 14:09:32 +0300 [thread overview]
Message-ID: <20150318110932.GT16501@mwanda> (raw)
In-Reply-To: <20141124235209.GA16222@mwanda>
Ping?
regards,
dan carpenter
On Tue, Nov 25, 2014 at 02:52:09AM +0300, Dan Carpenter wrote:
> Hello Vinod Koul,
>
> The patch 336cfbb05edf: "ASoC: Intel: mrfld- add ACPI module" from
> Nov 11, 2014, leads to the following static checker warning:
>
> sound/soc/intel/sst/sst_acpi.c:313 sst_acpi_probe()
> info: ignoring unreachable code.
>
> sound/soc/intel/sst/sst_acpi.c
> 304 ret = sst_context_init(ctx);
> 305 if (ret < 0)
> 306 return ret;
> 307
> 308 /* need to save shim registers in BYT */
> 309 ctx->shim_regs64 = devm_kzalloc(ctx->dev, sizeof(*ctx->shim_regs64),
> 310 GFP_KERNEL);
> 311 if (!ctx->shim_regs64) {
> 312 return -ENOMEM;
> ^^^^^^^^^^^^^^^
> 313 goto do_sst_cleanup;
> ^^^^^^^^^^^^^^^^^^^^
> 314 }
> 315
> 316 sst_configure_runtime_pm(ctx);
> 317 platform_set_drvdata(pdev, ctx);
> 318 return ret;
> 319
> 320 do_sst_cleanup:
> 321 sst_context_cleanup(ctx);
> 322 platform_set_drvdata(pdev, NULL);
> 323 dev_err(ctx->dev, "failed with %d\n", ret);
> 324 return ret;
> 325 }
>
> regards,
> dan carpenter
next prev parent reply other threads:[~2015-03-18 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 23:52 ASoC: Intel: mrfld- add ACPI module Dan Carpenter
2015-03-18 11:09 ` Dan Carpenter [this message]
2015-03-18 11:15 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318110932.GT16501@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.