From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregkh@linuxfoundation.org (Greg Kroah-Hartman) Date: Wed, 18 Mar 2015 13:28:54 +0100 Subject: [PATCH 1/5] USB: ehci-atmel: rework clk handling In-Reply-To: <55095E86.1060201@atmel.com> References: <55095E86.1060201@atmel.com> Message-ID: <20150318122854.GA18070@kroah.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Mar 18, 2015 at 12:16:22PM +0100, Nicolas Ferre wrote: > Le 17/03/2015 20:01, Alan Stern a ?crit : > > On Tue, 17 Mar 2015, Boris Brezillon wrote: > > > >> The EHCI IP only needs the UTMI/UPLL (uclk) and the peripheral (iclk) > >> clocks to work properly. Remove the useless system clock (fclk). > >> > >> Avoid calling set_rate on the fixed rate UTMI/IPLL clock and remove > >> useless IS_ENABLED(CONFIG_COMMON_CLK) tests (all at91 platforms have been > >> moved to the CCF). > >> > >> This patch also fixes a bug introduced by 3440ef1 (ARM: at91/dt: fix USB > >> high-speed clock to select UTMI), which was leaving the usb clock > >> uninitialized and preventing the OHCI driver from setting the usb clock > >> rate to 48MHz. > >> This bug was caused by several things: > >> 1/ usb clock drivers set the CLK_SET_RATE_GATE flag, which means the rate > >> cannot be changed once the clock is prepared > >> 2/ The EHCI driver was retrieving and preparing/enabling the uhpck > >> clock which was in turn preparing its parent clock (the usb clock), > >> thus preventing any rate change because of 1/ > >> > >> Signed-off-by: Boris Brezillon > > > > Acked-by: Alan Stern > > Acked-by: Nicolas Ferre > and: > Fixes: 3440ef169100 ("ARM: at91/dt: fix USB high-speed clock to select UTMI") > > Alan, Greg, > > Can you please take this patch (only this patch 1/5 of the series) as a fix > for the 4.0-rc? It would solve the issue that we see on at91sam9x5/at91sam9n12. > I'll take care of the rest of the series for 4.1. > > If you want me to take it of to re-send the patch, tell me. I'll queue it up now, thanks. You can take the rest of the series :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 1/5] USB: ehci-atmel: rework clk handling Date: Wed, 18 Mar 2015 13:28:54 +0100 Message-ID: <20150318122854.GA18070@kroah.com> References: <55095E86.1060201@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <55095E86.1060201-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Nicolas Ferre Cc: Alan Stern , Boris Brezillon , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Felipe Balbi , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Douglas Gilbert , Robert Nelson List-Id: devicetree@vger.kernel.org On Wed, Mar 18, 2015 at 12:16:22PM +0100, Nicolas Ferre wrote: > Le 17/03/2015 20:01, Alan Stern a =E9crit : > > On Tue, 17 Mar 2015, Boris Brezillon wrote: > >=20 > >> The EHCI IP only needs the UTMI/UPLL (uclk) and the peripheral (ic= lk) > >> clocks to work properly. Remove the useless system clock (fclk). > >> > >> Avoid calling set_rate on the fixed rate UTMI/IPLL clock and remov= e > >> useless IS_ENABLED(CONFIG_COMMON_CLK) tests (all at91 platforms ha= ve been > >> moved to the CCF). > >> > >> This patch also fixes a bug introduced by 3440ef1 (ARM: at91/dt: f= ix USB > >> high-speed clock to select UTMI), which was leaving the usb clock > >> uninitialized and preventing the OHCI driver from setting the usb = clock > >> rate to 48MHz. > >> This bug was caused by several things: > >> 1/ usb clock drivers set the CLK_SET_RATE_GATE flag, which means t= he rate > >> cannot be changed once the clock is prepared > >> 2/ The EHCI driver was retrieving and preparing/enabling the uhpck > >> clock which was in turn preparing its parent clock (the usb clo= ck), > >> thus preventing any rate change because of 1/ > >> > >> Signed-off-by: Boris Brezillon > >=20 > > Acked-by: Alan Stern >=20 > Acked-by: Nicolas Ferre > and: > Fixes: 3440ef169100 ("ARM: at91/dt: fix USB high-speed clock to selec= t UTMI") >=20 > Alan, Greg, >=20 > Can you please take this patch (only this patch 1/5 of the series) as= a fix=20 > for the 4.0-rc? It would solve the issue that we see on at91sam9x5/at= 91sam9n12. > I'll take care of the rest of the series for 4.1. >=20 > If you want me to take it of to re-send the patch, tell me. I'll queue it up now, thanks. You can take the rest of the series :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932890AbbCRM3B (ORCPT ); Wed, 18 Mar 2015 08:29:01 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60248 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755950AbbCRM27 (ORCPT ); Wed, 18 Mar 2015 08:28:59 -0400 Date: Wed, 18 Mar 2015 13:28:54 +0100 From: Greg Kroah-Hartman To: Nicolas Ferre Cc: Alan Stern , Boris Brezillon , Jean-Christophe Plagniol-Villard , Alexandre Belloni , Felipe Balbi , linux-usb@vger.kernel.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Douglas Gilbert , Robert Nelson Subject: Re: [PATCH 1/5] USB: ehci-atmel: rework clk handling Message-ID: <20150318122854.GA18070@kroah.com> References: <55095E86.1060201@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55095E86.1060201@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 12:16:22PM +0100, Nicolas Ferre wrote: > Le 17/03/2015 20:01, Alan Stern a écrit : > > On Tue, 17 Mar 2015, Boris Brezillon wrote: > > > >> The EHCI IP only needs the UTMI/UPLL (uclk) and the peripheral (iclk) > >> clocks to work properly. Remove the useless system clock (fclk). > >> > >> Avoid calling set_rate on the fixed rate UTMI/IPLL clock and remove > >> useless IS_ENABLED(CONFIG_COMMON_CLK) tests (all at91 platforms have been > >> moved to the CCF). > >> > >> This patch also fixes a bug introduced by 3440ef1 (ARM: at91/dt: fix USB > >> high-speed clock to select UTMI), which was leaving the usb clock > >> uninitialized and preventing the OHCI driver from setting the usb clock > >> rate to 48MHz. > >> This bug was caused by several things: > >> 1/ usb clock drivers set the CLK_SET_RATE_GATE flag, which means the rate > >> cannot be changed once the clock is prepared > >> 2/ The EHCI driver was retrieving and preparing/enabling the uhpck > >> clock which was in turn preparing its parent clock (the usb clock), > >> thus preventing any rate change because of 1/ > >> > >> Signed-off-by: Boris Brezillon > > > > Acked-by: Alan Stern > > Acked-by: Nicolas Ferre > and: > Fixes: 3440ef169100 ("ARM: at91/dt: fix USB high-speed clock to select UTMI") > > Alan, Greg, > > Can you please take this patch (only this patch 1/5 of the series) as a fix > for the 4.0-rc? It would solve the issue that we see on at91sam9x5/at91sam9n12. > I'll take care of the rest of the series for 4.1. > > If you want me to take it of to re-send the patch, tell me. I'll queue it up now, thanks. You can take the rest of the series :) thanks, greg k-h