From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
"H.J. Lu" <hjl.tools@gmail.com>, "H. Peter Anvin" <hpa@zytor.com>,
Namhyung Kim <namhyung@kernel.org>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] Check ARCH and IS_64_BIT instead of IS_X86_64 in perf
Date: Wed, 18 Mar 2015 10:10:54 -0300 [thread overview]
Message-ID: <20150318131054.GB2983@kernel.org> (raw)
In-Reply-To: <20150318094344.GA30872@krava.brq.redhat.com>
Em Wed, Mar 18, 2015 at 10:43:44AM +0100, Jiri Olsa escreveu:
> On Wed, Mar 18, 2015 at 10:24:10AM +0200, Adrian Hunter wrote:
> > Hi
> >
> > +Arnaldo
> > +Jiri
> >
> > I would change the commit message and subject. Say:
> >
> > Subject: perf tools: Fix perf-read-vdsox32 not building and lib64 install dir
> >
> > Commit:
> >
> > c6e5e9fbc3ea ("perf tools: Fix building error in x86_64 when dwarf unwind is on")
> >
> > removed the definition of IS_X86_64 but not all places
> > using it, with the consequence that perf-read-vdsox32
> > would not be built anymore, and the default lib install
> > directory was 'lib' instead of 'lib64'.
> >
> > Also needs to go to v3.19.
> >
> > Otherwise:
> >
> > Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: stable@vger.kernel.org # 3.19
>
> Acked-by: Jiri Olsa <jolsa@kernel.org>
Changed the commit log and applied, thanks,
- Arnaldo
next prev parent reply other threads:[~2015-03-18 13:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 22:33 [PATCH] Check ARCH and IS_64_BIT instead of IS_X86_64 in perf H.J. Lu
2015-03-18 8:24 ` Adrian Hunter
2015-03-18 9:43 ` Jiri Olsa
2015-03-18 13:10 ` Arnaldo Carvalho de Melo [this message]
2015-03-18 13:53 ` H.J. Lu
2015-03-22 10:08 ` [tip:perf/core] perf tools: Fix perf-read-vdsox32 not building and lib64 install dir tip-bot for H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318131054.GB2983@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=hjl.tools@gmail.com \
--cc=hpa@zytor.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.