From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756966AbbCRSu7 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Mar 2015 14:50:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35131 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755074AbbCRSu5 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Mar 2015 14:50:57 -0400
Date: Wed, 18 Mar 2015 15:50:48 -0300
From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: linux-kernel@vger.kernel.org, Corey Ashford <cjashfor@linux.vnet.ibm.com>,
        David Ahern <david.ahern@oracle.com>, Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>, Paul Mackerras <paulus@samba.org>,
        Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCHv2 00/15] tools build: Move features framework into
 tools/build
Message-ID: <20150318185048.GB3349@redhat.com>
References: <1426064344-21737-1-git-send-email-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426064344-21737-1-git-send-email-jolsa@kernel.org>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Em Wed, Mar 11, 2015 at 09:58:49AM +0100, Jiri Olsa escreveu:
> hi,
> moving features detection framework from perf to 'tools/build'
> plus other minor fixes.
> 
> v2 changes:
>   - omitted patch 1 from original version (Ingo)
>   - added features build output dump (Arnaldo)
>   - better scripting in features test (Namhyung)
>   - fixed test-all for pthread-attr-setaffinity-np
>   - removed main_test_libbabeltrace from test-all
>   - patches reordered
> 
> It's also available in:
>   git://git.kernel.org/pub/scm/linux/kernel/git/jolsa/perf.git
>   perf/build

Ok, so using the csets from the above branch, if I do:

[acme@ssdandy linux]$ rm -rf /tmp/build/perf ; mkdir -p /tmp/build/perf ; time make O=/tmp/build/perf -C tools/perf LIBBABELTRACE_DIR=/opt/libbabeltrace/ install-bin
make: Entering directory `/home/acme/git/linux/tools/perf'
  BUILD:   Doing 'make -j8' parallel build
config/Makefile:423: No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR

Auto-detecting system features:
...                         dwarf: [ on  ]
...                         glibc: [ on  ]
...                          gtk2: [ on  ]
...                      libaudit: [ on  ]
...                        libbfd: [ on  ]
...                        libelf: [ on  ]
...                       libnuma: [ on  ]
...                       libperl: [ on  ]
...                     libpython: [ on  ]
...                      libslang: [ on  ]
...                     libunwind: [ OFF ]
...            libdw-dwarf-unwind: [ on  ]
...                          zlib: [ on  ]
...     DWARF post unwind library: libdw

And then, despite not telling anything about babeltrace being linked,
i.e. the no line above with a [ on ], we get:

[acme@ssdandy linux]$ ldd ~/bin/perf | grep babel
	libbabeltrace-ctf.so.1 => /opt/libbabeltrace/lib/libbabeltrace-ctf.so.1 (0x00007f5f7b758000)
	libbabeltrace.so.1 => /opt/libbabeltrace/lib/libbabeltrace.so.1 (0x00007f5f7acfb000)
[acme@ssdandy linux]$

I.e. if a libbabeltrace-devel was installed and had what is needed to build it
in, when there would be no need for the LIBBABELTRACE_DIR above and babeltrace
wouldn't be either implicitely or explicitely specified as something we want to
build against we would not show it as a feature being built in (no
libbabeltrace: [ On ]) but would do it anyway, is that really the intention?

I tested in fedora, where no system auto-detection fails, i.e. test-all passes,
and the result is the same.

Ingo, can you clarify here?

- Arnaldo