From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Dilger, Andreas" <andreas.dilger@intel.com>
Cc: Maxime Lorrillere <maxime.lorrillere@lip6.fr>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"laure.millet@lip6.fr" <laure.millet@lip6.fr>
Subject: Re: [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit
Date: Wed, 18 Mar 2015 21:30:22 +0100 [thread overview]
Message-ID: <20150318203022.GA3288@kroah.com> (raw)
In-Reply-To: <D12F33AE.E6D1A%andreas.dilger@intel.com>
On Wed, Mar 18, 2015 at 07:53:35PM +0000, Dilger, Andreas wrote:
> On 2015/03/18, 1:07 PM, "Maxime Lorrillere" <maxime.lorrillere@lip6.fr>
> wrote:
>
> >From: Laure Millet <laure.millet@lip6.fr>
> >
> >This patch fixes lines over 80 characters
>
> I think the newer rule is that strings shouldn't be split across lines.
> That makes
> the first hunk invalid, though the second one is OK.
No, that first hunk is just fine, that horrid DFID macro allows it to
now be split :)
To fix this correctly, you need to move to using the "real" in-kernel
pr_err() functions, not custom macros. When that happens, checkpatch.pl
will stop complaining.
I'll take this one as-is.
thanks,
greg k-h
prev parent reply other threads:[~2015-03-18 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 19:07 [PATCH] staging: lustre: namei.c: coding style: fix 80 characters limit Maxime Lorrillere
2015-03-18 19:53 ` Dilger, Andreas
2015-03-18 20:30 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318203022.GA3288@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreas.dilger@intel.com \
--cc=laure.millet@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.lorrillere@lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.