From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756930AbbCRV7O (ORCPT ); Wed, 18 Mar 2015 17:59:14 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39341 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754880AbbCRV7N (ORCPT ); Wed, 18 Mar 2015 17:59:13 -0400 Date: Wed, 18 Mar 2015 22:59:09 +0100 From: Greg KH To: Redha Gouicem Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] Staging: lustre: lnet: lnet: router.c : fix 80 char limit Message-ID: <20150318215909.GA16096@kroah.com> References: <1426715147-15371-1-git-send-email-redha.gouicem@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426715147-15371-1-git-send-email-redha.gouicem@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 10:45:46PM +0100, Redha Gouicem wrote: > This fixes lines longer than 80 char which are not debug or error messages. > > Signed-off-by: Redha Gouicem > --- > drivers/staging/lustre/lnet/lnet/router.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c > index c0a6aeb..89a29b7 100644 > --- a/drivers/staging/lustre/lnet/lnet/router.c > +++ b/drivers/staging/lustre/lnet/lnet/router.c > @@ -107,7 +107,8 @@ lnet_peers_start_down(void) > } > > void > -lnet_notify_locked(lnet_peer_t *lp, int notifylnd, int alive, unsigned long when) > +lnet_notify_locked(lnet_peer_t *lp, int notifylnd, int alive, > + unsigned long when) > { > if (time_before(when, lp->lp_timestamp)) { /* out of date information */ > CDEBUG(D_NET, "Out of date\n"); > @@ -1435,7 +1436,8 @@ int > lnet_rtrpools_alloc(int im_a_router) > { > lnet_rtrbufpool_t *rtrp; > - int large_pages = (LNET_MTU + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT; > + int large_pages = (LNET_MTU + PAGE_CACHE_SIZE - 1) > + >> PAGE_CACHE_SHIFT; This last change doesn't really work in that it makes the code harder to read now. Yeah, the original code is a mess, one way to fix this would be to not do the assignment here in the variable initializer, but move it below in the code to be something like: int large_pages; .... large_pages = (LNET_MTU + PAGE_CACHE_SIZE - 1) >> PAGE_CACHE_SHIFT; Can you fix this patch up to look like this and resend? thanks, greg k-h