From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757168AbbCRWBU (ORCPT ); Wed, 18 Mar 2015 18:01:20 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:39349 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757118AbbCRWBP (ORCPT ); Wed, 18 Mar 2015 18:01:15 -0400 Date: Wed, 18 Mar 2015 23:01:11 +0100 From: Greg KH To: Redha Gouicem Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] Staging: lustre: lnet: lnet: router.c: fix useless statements Message-ID: <20150318220111.GA20501@kroah.com> References: <1426715147-15371-1-git-send-email-redha.gouicem@gmail.com> <1426715147-15371-2-git-send-email-redha.gouicem@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426715147-15371-2-git-send-email-redha.gouicem@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 10:45:47PM +0100, Redha Gouicem wrote: > This patch removes useless returns and elses. > > Signed-off-by: Redha Gouicem > --- > drivers/staging/lustre/lnet/lnet/router.c | 15 ++++----------- > 1 file changed, 4 insertions(+), 11 deletions(-) > > diff --git a/drivers/staging/lustre/lnet/lnet/router.c b/drivers/staging/lustre/lnet/lnet/router.c > index 89a29b7..6fe79e2 100644 > --- a/drivers/staging/lustre/lnet/lnet/router.c > +++ b/drivers/staging/lustre/lnet/lnet/router.c > @@ -270,7 +270,6 @@ static void lnet_shuffle_seed(void) > do_gettimeofday(&tv); > cfs_srand(tv.tv_sec ^ seed[0], tv.tv_usec ^ seed[1]); > seeded = 1; > - return; > } > > /* NB expects LNET_LOCK held */ > @@ -357,11 +356,10 @@ lnet_add_route(__u32 net, unsigned int hops, lnet_nid_t gateway, > > if (rc == -EHOSTUNREACH) { /* gateway is not on a local net */ > return 0; /* ignore the route entry */ > - } else { > - CERROR("Error %d creating route %s %d %s\n", rc, > - libcfs_net2str(net), hops, > - libcfs_nid2str(gateway)); > - } > + CERROR("Error %d creating route %s %d %s\n", rc, > + libcfs_net2str(net), hops, > + libcfs_nid2str(gateway)); > + > return rc; > } > This change broke the build :( Please always test build your changes, cna you fix it up and resend? thanks, greg k-h