From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/dvdrw-tools: fix incorrect default choiche
Date: Wed, 18 Mar 2015 23:41:11 +0100 [thread overview]
Message-ID: <20150318224111.GA4578@free.fr> (raw)
In-Reply-To: <1426631327-15489-1-git-send-email-angelo.compagnucci@gmail.com>
Angelo, All,
On 2015-03-17 23:28 +0100, Angelo Compagnucci spake thusly:
> This pathc fixes default choiche BR2_PACKAGE_DVDRW_TOOLS_CDRKIT_BACKEND.
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
> ---
> package/dvdrw-tools/Config.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/dvdrw-tools/Config.in b/package/dvdrw-tools/Config.in
> index 6787b66..fb4d4c2 100644
> --- a/package/dvdrw-tools/Config.in
> +++ b/package/dvdrw-tools/Config.in
> @@ -35,7 +35,7 @@ config BR2_PACKAGE_DVDRW_TOOLS
> if BR2_PACKAGE_DVDRW_TOOLS
> choice
> prompt "Media Backend"
> - default BR2_PACKAGE_DVDRW_CDRKIT_BACKEND
> + default BR2_PACKAGE_DVDRW_TOOLS_CDRKIT_BACKEND
In fact that's not needed since cdrkit is the first entry.
Besides, and I missed it durign the review too, we can't force cdrkit as
the default sicne it has a dependency which is not reported here; it
should have been (options elided for readability):
choice
bool "backend"
default CDRKIT if HEADERS_AT_LEAST_3_0
But really, there's no reason to have a default in the first place, so I
suggest we just get rid of it:
- if kernel headers >= 3.0, cdrkit will be used by default as it is
the first entry in the choice;
- otherwise, cdrkit will be unavailable, and xorriso will be used.
Regards,
Yann E. MORIN.
> help
> Choose which media backend program to use.
>
> --
> 1.9.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
prev parent reply other threads:[~2015-03-18 22:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 22:28 [Buildroot] [PATCH] package/dvdrw-tools: fix incorrect default choiche Angelo Compagnucci
2015-03-18 5:03 ` Steve Kenton
2015-03-18 22:41 ` Yann E. MORIN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150318224111.GA4578@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.