All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org, Mike Waychison <mikew@google.com>,
	Greg KH <greg@kroah.com>
Subject: Re: [PATCH] x86: remove unused get_bios_ebda_length
Date: Thu, 19 Mar 2015 12:16:44 +0100	[thread overview]
Message-ID: <20150319111643.GA11530@pd.tnic> (raw)
In-Reply-To: <1426762537-25273-1-git-send-email-kuleshovmail@gmail.com>

On Thu, Mar 19, 2015 at 04:55:37PM +0600, Alexander Kuleshov wrote:
> get_bios_ebda_length function from <asm/bios_ebda.h> was added
> in the 57d5f9f808b7650a92f31e9cd3acd3f415a22530 commit, but

You probably should've added the people involved in that commit to CC.
They might still need it, although I doubt it. :-)

> still not uses anywhere, let's remove it.
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>
> ---
>  arch/x86/include/asm/bios_ebda.h | 21 ---------------------
>  1 file changed, 21 deletions(-)
> 
> diff --git a/arch/x86/include/asm/bios_ebda.h b/arch/x86/include/asm/bios_ebda.h
> index aa6a317..2b00c77 100644
> --- a/arch/x86/include/asm/bios_ebda.h
> +++ b/arch/x86/include/asm/bios_ebda.h
> @@ -17,27 +17,6 @@ static inline unsigned int get_bios_ebda(void)
>  	return address;	/* 0 means none */
>  }
>  
> -/*
> - * Return the sanitized length of the EBDA in bytes, if it exists.
> - */
> -static inline unsigned int get_bios_ebda_length(void)
> -{
> -	unsigned int address;
> -	unsigned int length;
> -
> -	address = get_bios_ebda();
> -	if (!address)
> -		return 0;
> -
> -	/* EBDA length is byte 0 of the EBDA (stored in KiB) */
> -	length = *(unsigned char *)phys_to_virt(address);
> -	length <<= 10;
> -
> -	/* Trim the length if it extends beyond 640KiB */
> -	length = min_t(unsigned int, (640 * 1024) - address, length);
> -	return length;
> -}
> -
>  void reserve_ebda_region(void);
>  
>  #ifdef CONFIG_X86_CHECK_BIOS_CORRUPTION
> -- 
> 2.3.3.472.g20ceeac.dirty
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--

      reply	other threads:[~2015-03-19 11:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19 10:55 [PATCH] x86: remove unused get_bios_ebda_length Alexander Kuleshov
2015-03-19 11:16 ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150319111643.GA11530@pd.tnic \
    --to=bp@alien8.de \
    --cc=greg@kroah.com \
    --cc=hpa@zytor.com \
    --cc=kuleshovmail@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikew@google.com \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.