From: Borislav Petkov <bp@suse.de>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Xie XiuQi <xiexiuqi@huawei.com>,
akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com,
gong.chen@linux.intel.com, bhelgaas@google.com,
tony.luck@intel.com, linux-kernel@vger.kernel.org,
jingle.chen@huawei.com
Subject: Re: [PATCH] trace, RAS: remove unnecessary const
Date: Thu, 19 Mar 2015 14:10:47 +0100 [thread overview]
Message-ID: <20150319131047.GE11544@pd.tnic> (raw)
In-Reply-To: <20150319085756.2c649e7d@gandalf.local.home>
On Thu, Mar 19, 2015 at 08:57:56AM -0400, Steven Rostedt wrote:
> That's a bit of a stretch. But sure, there's no real downside to having
> it, except that it makes one take a double take when seeing it, and
> thinking about why it would even be needed (like I did).
Why? It simply declares the contract that this argument won't be
changed. And if there's no downside, there's no need to do anything
here.
> I think you had the crazy fantasy with the above patch!
Wasn't me.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
prev parent reply other threads:[~2015-03-19 13:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 8:50 [PATCH] trace, RAS: remove unnecessary const Xie XiuQi
2015-03-19 10:33 ` Borislav Petkov
2015-03-19 11:57 ` Xie XiuQi
2015-03-19 13:00 ` Steven Rostedt
2015-03-20 4:05 ` Xie XiuQi
2015-03-19 12:57 ` Steven Rostedt
2015-03-19 13:10 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319131047.GE11544@pd.tnic \
--to=bp@suse.de \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=gong.chen@linux.intel.com \
--cc=jingle.chen@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rostedt@goodmis.org \
--cc=tony.luck@intel.com \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.