Re: [PATCH] tools: unbreak 'make tools/*'

[Jiri Olsa <jolsa@redhat.com>]

On Thu, Mar 19, 2015 at 10:39:25AM -0300, Arnaldo Carvalho de Melo wrote:

SNIP

> [acme@ssdandy linux]$
> 
> -------------------------------------------------------
> 
> Jiri, can you take a look at the above?
> 
> It works if I use 'make -C', with O=, like I usually do, or without it:
> 
> -------------------------------------------------------
> 
> [acme@ssdandy linux]$ make -C tools/perf
> make: Entering directory `/home/acme/git/linux/tools/perf'
>   BUILD:   Doing 'make -j8' parallel build
> 
> Auto-detecting system features:
> ...                         dwarf: [ on  ]
> ...                         glibc: [ on  ]
> <SNIP>
> ...                     libunwind: [ OFF ]
> ...            libdw-dwarf-unwind: [ on  ]
> ...                          zlib: [ on  ]
> 
> config/Makefile:308: No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR
> config/Makefile:598: No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev
>   GEN      common-cmds.h
>   CC       util/abspath.o
>   CC       ui/setup.o
>   CC       arch/common.o
> 
> 
> -------------------------------------------------------
> 
> Can you please check these issues, using my perf/core branch at:

hum, I've never cared about tools/Makefile :-\

so this is what we want to be able to do/use? :

  $ make tools/
  $ make tools/perf
  $ make O=$(BUILDDIR) tools/perf

it ^^^ does not work for me even with this patch
(tools/Makefile still using 'libapikfs' being first issue I saw)

I'll check and send fix

jirka