All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: percpu: Make this_cpu accessors pre-empt safe
Date: Thu, 19 Mar 2015 16:23:01 +0000	[thread overview]
Message-ID: <20150319162300.GF25967@leverpostej> (raw)
In-Reply-To: <CAPvkgC2ntPrTVKi_WxHcMHqV2Rt9KZR9u-oUqVHNH8+1=nnnDg@mail.gmail.com>

> > It's a shame there don't seem to be any this_cpu_* self-tests; I've
> > booted a kernel with this applied, but I didn't have anything that
> > exploded without this, so I'd feel uneasy giving a Tested-by.
> 
> There is the percpu_test module, I ran this and it appeared to pass.
> Also, I ran the traditional hackbench tests.

I haan't spotted the percpu_test module, but looking at it, it seems to
be effectively useless. The body of the test is:

static int __init percpu_test_init(void)
{
	pr_info("percpu test start\n");
	preempt_disable();

	...
	/*
	 * test each this_cpu operation in turn
	 */
	...

	preempt_enable();
	pr_info("percpu test done\n");

	return -EAGAIN;
}

Which doesn't stress the this_cpu operations at all, unless you consider
the hard part to be the maths ;)

To test this patch thoroughly we need something that has a few threads
which perform some common use patterns (while getting migrated),
checking that they end up with consistent and the system doesn't lockup
or explode.

Mark.

  reply	other threads:[~2015-03-19 16:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19 14:52 [PATCH] arm64: percpu: Make this_cpu accessors pre-empt safe Steve Capper
2015-03-19 15:44 ` Mark Rutland
2015-03-19 15:55   ` Steve Capper
2015-03-19 16:23     ` Mark Rutland [this message]
2015-03-19 16:00   ` Will Deacon
2015-03-19 16:11     ` Mark Rutland
2015-03-19 16:27       ` Will Deacon
2015-03-19 16:39         ` Mark Rutland
2015-03-20 18:02           ` Will Deacon
2015-03-22 14:51             ` [PATCH V2] " Steve Capper
2015-03-23 10:17               ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150319162300.GF25967@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.