From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v2 07/13] libxc: Fix xc_tmem_control to return proper error. Date: Thu, 19 Mar 2015 14:52:34 -0400 Message-ID: <20150319185234.GB21217@x230.dumpdata.com> References: <1426724659-23999-1-git-send-email-konrad.wilk@oracle.com> <1426724659-23999-8-git-send-email-konrad.wilk@oracle.com> <1426783189.21742.70.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YYfYp-0005oR-4w for xen-devel@lists.xenproject.org; Thu, 19 Mar 2015 18:52:51 +0000 Content-Disposition: inline In-Reply-To: <1426783189.21742.70.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, Mar 19, 2015 at 04:39:49PM +0000, Ian Campbell wrote: > On Wed, 2015-03-18 at 20:24 -0400, Konrad Rzeszutek Wilk wrote: > > The API returns now negative values on error and stashes > > the error in errno. Fix the user of this API. > > > > The 'xc_hypercall_bounce_pre' can fail - and if so it will > > stash its errno values - no need to over-write it. > > > > Signed-off-by: Konrad Rzeszutek Wilk > > Acked-by: Ian Campbell > > I'm still a little concerned about xenstat.c's handling of errno! > =-ENOSYS, but not enough to nack. You mean not handling it :-) Yeah, there is certainly some more tmem related changes (another wrapper function) so that it returns 0 when 'tmem' is not enabled (and not modify 'errno'). But not this week.. > >