From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/4] drm/i915: Eliminate the RMW sprite colorkey management
Date: Thu, 19 Mar 2015 20:57:03 +0200 [thread overview]
Message-ID: <20150319185702.GT17419@intel.com> (raw)
In-Reply-To: <20150319164613.GF31422@phenom.ffwll.local>
On Thu, Mar 19, 2015 at 05:46:13PM +0100, Daniel Vetter wrote:
> On Thu, Mar 19, 2015 at 05:57:12PM +0200, ville.syrjala@linux.intel.com wrote:
> > @@ -1332,7 +1167,7 @@ int intel_sprite_set_colorkey(struct drm_device *dev, void *data,
> > }
> >
> > intel_plane = to_intel_plane(plane);
> > - ret = intel_plane->update_colorkey(plane, set);
> > + intel_plane->ckey = *set;
>
> I really liked this and wanted to merge, but then realized that this hunk
> removes the update for the ioctl. I think we need to put and update_plane
> call or similar in here?
Doh. Yeah meant to add that and just forgot. I'll respin.
>
> Also we still have the RMW for the sprite control register - aren't we
> know at a point where there's nothing left to keep?
See the next patch.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-03-19 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 15:57 [PATCH 1/4] drm/i915: Kill intel_plane->obj ville.syrjala
2015-03-19 15:57 ` [PATCH 2/4] drm/i915: Eliminate the RMW sprite colorkey management ville.syrjala
2015-03-19 16:46 ` Daniel Vetter
2015-03-19 18:57 ` Ville Syrjälä [this message]
2015-03-20 10:48 ` Daniel Vetter
2015-03-19 19:18 ` [PATCH v2 " ville.syrjala
2015-03-19 15:57 ` [PATCH 3/4] drm/i915: Eliminate plane control register RMW from sprite code ville.syrjala
2015-03-19 15:57 ` [PATCH 4/4] drm/i915: Fix SKL sprite disable double buffer register update ville.syrjala
2015-03-20 3:12 ` shuang.he
2015-03-19 16:46 ` [PATCH 1/4] drm/i915: Kill intel_plane->obj Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319185702.GT17419@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.