All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
	Marcelo Tosatti <mtosatti@redhat.com>,
	chao.zhou@intel.com
Subject: Re: [PATCH] KVM: x86: call irq notifiers with directed EOI
Date: Thu, 19 Mar 2015 20:42:54 +0100	[thread overview]
Message-ID: <20150319194253.GA3584@potion.brq.redhat.com> (raw)
In-Reply-To: <550B065F.6040603@redhat.com>

2015-03-19 18:24+0100, Paolo Bonzini:
> > diff --git a/arch/x86/kvm/lapic.c b/arch/x86/kvm/lapic.c
> > @@ -833,8 +833,7 @@ int kvm_apic_compare_prio(struct kvm_vcpu *vcpu1, struct kvm_vcpu *vcpu2)
> > -	if (!(kvm_apic_get_reg(apic, APIC_SPIV) & APIC_SPIV_DIRECTED_EOI) &&
> > -	    kvm_ioapic_handles_vector(apic->vcpu->kvm, vector)) {
> > +	if (kvm_ioapic_handles_vector(apic->vcpu->kvm, vector)) {
> 
> Can you look into making kvm_ioapic_handles_vector inline in ioapic.h?

Will do.

> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>

Thanks.

  reply	other threads:[~2015-03-19 19:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 18:38 [PATCH] KVM: x86: call irq notifiers with directed EOI Radim Krčmář
2015-03-18 19:37 ` Bandan Das
2015-03-18 20:16   ` Radim Krčmář
2015-03-18 20:50 ` Bandan Das
2015-03-19 17:24 ` Paolo Bonzini
2015-03-19 19:42   ` Radim Krčmář [this message]
2015-03-19 21:44 ` Marcelo Tosatti
2015-03-20 14:43   ` Radim Krčmář
2015-03-23 23:27 ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150319194253.GA3584@potion.brq.redhat.com \
    --to=rkrcmar@redhat.com \
    --cc=chao.zhou@intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.