From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 1/3] i2c: slave: rework the slave API Date: Thu, 19 Mar 2015 21:17:51 +0100 Message-ID: <20150319201751.GZ10068@pengutronix.de> References: <1426164123-8853-1-git-send-email-wsa@the-dreams.de> <1426164123-8853-2-git-send-email-wsa@the-dreams.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1426164123-8853-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Magnus Damm , Simon Horman , Laurent Pinchart , Geert Uytterhoeven , Andrey Danin , Marc Dietrich , Debora Grosse , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org Hello Wolfram, On Thu, Mar 12, 2015 at 01:42:01PM +0100, Wolfram Sang wrote: > From: Wolfram Sang >=20 > After more discussion, brave users, and additional datasheet evaluati= on, > some API updates for the new I2C slave framework became imminent. The > slave events now get some easier to understand naming. Also, the even= t > handling has been simplified to only send one event per interrupt. what is an interrupt here? An event where the bus driver needs feedback from the backend? Other than that the patch looks fine. Thanks for working on my feedback= ! Acked-by: Uwe Kleine-K=F6nig Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig = | Industrial Linux Solutions | http://www.pengutronix.de/= | From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Date: Thu, 19 Mar 2015 20:17:51 +0000 Subject: Re: [PATCH 1/3] i2c: slave: rework the slave API Message-Id: <20150319201751.GZ10068@pengutronix.de> List-Id: References: <1426164123-8853-1-git-send-email-wsa@the-dreams.de> <1426164123-8853-2-git-send-email-wsa@the-dreams.de> In-Reply-To: <1426164123-8853-2-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Wolfram Sang Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Magnus Damm , Simon Horman , Laurent Pinchart , Geert Uytterhoeven , Andrey Danin , Marc Dietrich , Debora Grosse , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Hello Wolfram, On Thu, Mar 12, 2015 at 01:42:01PM +0100, Wolfram Sang wrote: > From: Wolfram Sang >=20 > After more discussion, brave users, and additional datasheet evaluation, > some API updates for the new I2C slave framework became imminent. The > slave events now get some easier to understand naming. Also, the event > handling has been simplified to only send one event per interrupt. what is an interrupt here? An event where the bus driver needs feedback from the backend? Other than that the patch looks fine. Thanks for working on my feedback! Acked-by: Uwe Kleine-K=F6nig Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751383AbbCSUVQ (ORCPT ); Thu, 19 Mar 2015 16:21:16 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:56755 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751127AbbCSUVO (ORCPT ); Thu, 19 Mar 2015 16:21:14 -0400 Date: Thu, 19 Mar 2015 21:17:51 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Simon Horman , Laurent Pinchart , Geert Uytterhoeven , Andrey Danin , Marc Dietrich , Debora Grosse , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] i2c: slave: rework the slave API Message-ID: <20150319201751.GZ10068@pengutronix.de> References: <1426164123-8853-1-git-send-email-wsa@the-dreams.de> <1426164123-8853-2-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1426164123-8853-2-git-send-email-wsa@the-dreams.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Wolfram, On Thu, Mar 12, 2015 at 01:42:01PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > After more discussion, brave users, and additional datasheet evaluation, > some API updates for the new I2C slave framework became imminent. The > slave events now get some easier to understand naming. Also, the event > handling has been simplified to only send one event per interrupt. what is an interrupt here? An event where the bus driver needs feedback from the backend? Other than that the patch looks fine. Thanks for working on my feedback! Acked-by: Uwe Kleine-König Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |