From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Kyle J. McKay" <mackyle@gmail.com>,
Git mailing list <git@vger.kernel.org>
Subject: Re: Bug in fetch-pack.c, please confirm
Date: Thu, 19 Mar 2015 16:31:26 -0400 [thread overview]
Message-ID: <20150319203126.GA31663@peff.net> (raw)
In-Reply-To: <xmqqtwxgizg9.fsf@gitster.dls.corp.google.com>
On Thu, Mar 19, 2015 at 12:01:26PM -0700, Junio C Hamano wrote:
> > I'm working up a few patches in that area, which I'll send out in a few
> > minutes. Once that is done, then I think the explanation you give above
> > would be correct.
>
> If a follow-up is coming then I'd just drop this one. Thanks.
OK, here it is. Took me a bit longer than I expected, as I wanted to
figure out whether the second patch was actually fixing a bug (and if
so, to add test coverage). Turns out that it is a real bug.
The final patch is what you sent, rebased on top (though there are not
any code changes; the underlying commits make the _explanation_ true,
but no code change was required). I fixed up the nits I mentioned in my
earlier email.
[1/4]: filter_ref: avoid overwriting ref->old_sha1 with garbage
[2/4]: filter_ref: make a copy of extra "sought" entries
[3/4]: fetch_refs_via_pack: free extra copy of refs
[4/4]: fetch-pack: remove dead assignment to ref->new_sha1
-Peff
next prev parent reply other threads:[~2015-03-19 20:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 6:37 Bug in fetch-pack.c, please confirm Kyle J. McKay
2015-03-15 7:27 ` Junio C Hamano
2015-03-15 7:30 ` Junio C Hamano
2015-03-15 22:21 ` Kyle J. McKay
2015-03-16 1:13 ` Jeff King
2015-03-19 17:41 ` Junio C Hamano
2015-03-19 18:55 ` Jeff King
2015-03-19 19:01 ` Junio C Hamano
2015-03-19 20:31 ` Jeff King [this message]
2015-03-19 20:34 ` [PATCH 1/4] filter_ref: avoid overwriting ref->old_sha1 with garbage Jeff King
2015-03-19 21:09 ` Junio C Hamano
2015-03-19 20:37 ` [PATCH 2/4] filter_ref: make a copy of extra "sought" entries Jeff King
2015-03-19 20:38 ` [PATCH 3/4] fetch_refs_via_pack: free extra copy of refs Jeff King
2015-03-19 20:39 ` [PATCH 4/4] fetch-pack: remove dead assignment to ref->new_sha1 Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319203126.GA31663@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mackyle@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.