From: Jeff King <peff@peff.net>
To: Stephen Morton <stephen.c.morton@gmail.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: Slow git pushes: sitting 1 minute in pack-objects
Date: Thu, 19 Mar 2015 17:07:31 -0400 [thread overview]
Message-ID: <20150319210731.GA8363@peff.net> (raw)
In-Reply-To: <CAH8BJxErCMk1JQMMKm9_j4bckB7bEVB+r28_zYovE=pe1nUa_Q@mail.gmail.com>
On Thu, Mar 19, 2015 at 04:31:36PM -0400, Stephen Morton wrote:
> > Hmm. The "push" process must feed the set of object boundaries to
> > "pack-objects" so it knows what to pack (i.e., what we want to send, and
> > what the other side has).
> >
> > 120,000 is an awfully large number of objects to be pass there, though.
> > Does the repo you are pushing to by any chance have an extremely large
> > number of refs (e.g., on the order of 120K tags)?
>
> No. There are on the order of 9,500 refs (mostly tags) but nowhere near 120k.
I think you mentioned that it uses alternates to share objects with
other repos. Does the repository (or repositories) pointed to by the
alternates file have a large number of refs (especially distinct refs,
as I think modern git will squelch duplicate sha1s).
> It did _not_ happen in a new clone --a push took just 5s -- and I
> think the culprit could have been "repack.writebitmaps=true". Although
> I had thought writebitmaps was not originally enabled, I now suspect
> that it was. Let me follow up on that first, before I recompile git
> with your changes.
It's certainly possible that bitmaps have an impact here. They should
not contribute to the 120K objects being passed to pack-objects, but
it's possible that size is a red herring (or possibly the number of
objects is choking something in the bitmap code path that does not have
problems otherwise).
-Peff
prev parent reply other threads:[~2015-03-19 21:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-05 21:03 Slow git pushes: sitting 1 minute in pack-objects Stephen Morton
2015-03-06 0:25 ` Duy Nguyen
2015-03-06 0:37 ` Stephen Morton
2015-03-09 7:53 ` Jeff King
2015-03-10 1:37 ` Stephen Morton
2015-03-16 22:15 ` Jeff King
2015-03-19 20:31 ` Stephen Morton
2015-03-19 21:07 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150319210731.GA8363@peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=stephen.c.morton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.