From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34026) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYiYs-0006ff-8D for qemu-devel@nongnu.org; Thu, 19 Mar 2015 18:05:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYiYm-0007VJ-Cu for qemu-devel@nongnu.org; Thu, 19 Mar 2015 18:05:06 -0400 Received: from smtp3.mundo-r.com ([212.51.32.191]:47091 helo=smtp4.mundo-r.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYiYm-0007V3-5l for qemu-devel@nongnu.org; Thu, 19 Mar 2015 18:05:00 -0400 Date: Thu, 19 Mar 2015 23:04:57 +0100 From: Alberto Garcia Message-ID: <20150319220457.GA22704@igalia.com> References: <9d3f0e0ee6fcfc6300e165f79b46a4af0ffdc37d.1426779661.git.berto@igalia.com> <550B26AB.4050806@redhat.com> <20150319214201.GA11212@igalia.com> <550B4534.108@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <550B4534.108@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/3] block: allow BLOCK_IMAGE_CORRUPTED to have a node name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: Kevin Wolf , qemu-devel@nongnu.org, Stefan Hajnoczi On Thu, Mar 19, 2015 at 05:52:52PM -0400, Max Reitz wrote: > So in this case here I don't really see a benefit of reusing @device > instead of just adding @node-name, whereas adding @node-name will > have the benefit of not affecting anybody and (in my opinion) being > more explicit. However, if others tend to think otherwise (the > @node-name vs. @node vs. @device is a constant point of dissent > over naming...), I'm happy to be convinced otherwise. In the end it > doesn't really matter after all, it's a machine-readable protocol. > If software can work with it, it's fine. It's fine with me as well, I just had the impression that there was a consensus towards not extending the API if possible, but in my case I'm happy to implement whichever alternative. Berto