From: Kalle Valo <kvalo@codeaurora.org>
To: Jeff Layton <jeff.layton@primarydata.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>, linux-wireless@vger.kernel.org
Subject: Re: rtl8188ee: fix build break due to missing rtl_hal_pwrseqcmdparsingdefinition
Date: Fri, 20 Mar 2015 06:30:08 +0000 (UTC) [thread overview]
Message-ID: <20150320063008.965E3140B84@smtp.codeaurora.org> (raw)
In-Reply-To: <1426349237-7501-1-git-send-email-jeff.layton@primarydata.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 1161 bytes --]
> I've been getting this error when building mainline kernels using
> Fedora's config files:
>
> drivers/net/wireless/rtlwifi/rtl8188ee/hw.c: In function ‘_rtl88ee_init_mac’:
> drivers/net/wireless/rtlwifi/rtl8188ee/hw.c:853:2: error: implicit declaration of function ‘rtl_hal_pwrseqcmdparsing’ [-Werror=implicit-function-declaration]
> if (!rtl_hal_pwrseqcmdparsing(rtlpriv, PWR_CUT_ALL_MSK,
> ^
> cc1: some warnings being treated as errors
> scripts/Makefile.build:258: recipe for target 'drivers/net/wireless/rtlwifi/rtl8188ee/hw.o' failed
>
> I'm not sure if this is the correct fix, but it does seem to allow the
> build to complete. I suspect that this was broken by commit 34ed780a6afc
> (rtlwifi: Fix problems with building an allyesconfig). Most of the files
> that removed the include of pwrseqcmd.h, added one for ../pwrseqcmd.h.
> The rtl8188ee driver had it removed it but didn't add the include of the
> file in the parent directory.
>
> Signed-off-by: Jeff Layton <jeff.layton@primarydata.com>
> Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Thanks, applied to wireless-drivers-next.git.
Kalle Valo
prev parent reply other threads:[~2015-03-20 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 16:07 [PATCH] rtl8188ee: fix build break due to missing rtl_hal_pwrseqcmdparsing definition Jeff Layton
2015-03-14 16:29 ` Larry Finger
2015-03-14 16:35 ` Jeff Layton
2015-03-14 17:51 ` Larry Finger
2015-03-20 6:30 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320063008.965E3140B84@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=jeff.layton@primarydata.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.