From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39996) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYu2L-0006jB-4S for qemu-devel@nongnu.org; Fri, 20 Mar 2015 06:20:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYu2H-0004bm-U9 for qemu-devel@nongnu.org; Fri, 20 Mar 2015 06:20:17 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:56165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYu2H-0004b1-KL for qemu-devel@nongnu.org; Fri, 20 Mar 2015 06:20:13 -0400 Received: from /spool/local by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 20 Mar 2015 10:20:11 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id C90B11B08069 for ; Fri, 20 Mar 2015 10:20:32 +0000 (GMT) Received: from d06av04.portsmouth.uk.ibm.com (d06av04.portsmouth.uk.ibm.com [9.149.37.216]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2KAK8oW4915514 for ; Fri, 20 Mar 2015 10:20:08 GMT Received: from d06av04.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av04.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2KAK7oU027788 for ; Fri, 20 Mar 2015 04:20:08 -0600 Date: Fri, 20 Mar 2015 11:20:05 +0100 From: Cornelia Huck Message-ID: <20150320112005.12d9ea52.cornelia.huck@de.ibm.com> In-Reply-To: <1426671309-13645-10-git-send-email-jasowang@redhat.com> References: <1426671309-13645-1-git-send-email-jasowang@redhat.com> <1426671309-13645-10-git-send-email-jasowang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 09/19] virito: introduce bus specific queue limit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: mst@redhat.com, Alexander Graf , qemu-devel@nongnu.org, Christian Borntraeger , Paolo Bonzini , Richard Henderson On Wed, 18 Mar 2015 17:34:59 +0800 Jason Wang wrote: Typo in subject: s/virito/virtio/ > This patch introduces a bus specific queue limitation. It will be > useful for increasing the limit for one of the bus without disturbing > other buses. > > Cc: Michael S. Tsirkin > Cc: Alexander Graf > Cc: Richard Henderson > Cc: Cornelia Huck > Cc: Christian Borntraeger > Cc: Paolo Bonzini > Signed-off-by: Jason Wang > --- > hw/char/virtio-serial-bus.c | 2 +- > hw/net/virtio-net.c | 4 ++-- > hw/s390x/s390-virtio-bus.c | 1 + > hw/s390x/virtio-ccw.c | 1 + > hw/scsi/virtio-scsi.c | 4 ++-- > hw/virtio/virtio-mmio.c | 1 + > hw/virtio/virtio-pci.c | 1 + > hw/virtio/virtio.c | 40 +++++++++++++++++++++++++--------------- > include/hw/virtio/virtio-bus.h | 1 + > include/hw/virtio/virtio.h | 1 + > 10 files changed, 36 insertions(+), 20 deletions(-) > diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c > index 047c963..2b41e32 100644 > --- a/hw/s390x/s390-virtio-bus.c > +++ b/hw/s390x/s390-virtio-bus.c > @@ -715,6 +715,7 @@ static void virtio_s390_bus_class_init(ObjectClass *klass, void *data) > bus_class->max_dev = 1; > k->notify = virtio_s390_notify; > k->get_features = virtio_s390_get_features; > + k->queue_max = VIRTIO_PCI_QUEUE_MAX; I'm wondering whether we should initialize queue_max to smth like VIRTIO_QUEUE_MAX_DEFAULT (== 64) in virtio-bus.c instead and have the individual classes override that value once they want to use a different value? But I'm fine with this patch as it stands as well. > }