All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Darshana Padmadas <darshanapadmadas@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2 1/5] Staging: rtl8192e: Replace memcpy with ether_addr_copy
Date: Fri, 20 Mar 2015 13:10:41 +0100	[thread overview]
Message-ID: <20150320121041.GA19110@kroah.com> (raw)
In-Reply-To: <9eab4a1c89f930dac0710fda702a6de414172237.1426685762.git.darshanapadmadas@gmail.com>

On Wed, Mar 18, 2015 at 07:13:19PM +0530, Darshana Padmadas wrote:
> This patch fixes the following warning found by checkpatch.pl:
> Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2
> 
> Also included header file linux/etherdevice.h that defines 
> ether_addr_copy.

<snip>

This series still adds kernel build warnings, which is not allowed.  It
looks like the patches are actually incorrect, and the compiler is
correctly warning you about this.

Please fix this up, TEST THEM!!!, and then resend.

thanks,

greg k-h


  reply	other threads:[~2015-03-20 14:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 13:43 [PATCH v2 0/5] Replace memcpy with ether_addr_copy and fix checkpatch warning Darshana Padmadas
2015-03-18 13:43 ` [PATCH v2 1/5] Staging: rtl8192e: Replace memcpy with ether_addr_copy Darshana Padmadas
2015-03-20 12:10   ` Greg KH [this message]
2015-03-18 13:43 ` [PATCH v2 2/5] Staging: rtl8192e: Use ether_addr_copy instead of memcpy Darshana Padmadas
2015-03-18 13:43 ` [PATCH v2 3/5] Staging: rtl8192e: Use ether_addr_copy replacing memcpy Darshana Padmadas
2015-03-18 13:43 ` [PATCH v2 4/5] Staging: rtl8192e: Use ether_addr_copy for aligned addresses Darshana Padmadas
2015-03-20 11:01   ` Darshana Padmadas
2015-03-18 13:43 ` [PATCH v2 5/5] Staging: rtl8192e: replace memcpy with ether_addr_copy for aligned structures Darshana Padmadas
  -- strict thread matches above, loose matches on Subject: below --
2015-03-16 19:18 [PATCH 1/5] Staging: rtl8192e: Replace memcpy with ether_addr_copy Darshana Padmadas
2015-03-18 12:34 ` [PATCH v2 " Darshana Padmadas
2015-03-18 12:36   ` [Outreachy kernel] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150320121041.GA19110@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=darshanapadmadas@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.