All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Vatika Harlalka <vatikaharlalka@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: wlan-ng: Remove struct typedefs
Date: Fri, 20 Mar 2015 13:20:40 +0100	[thread overview]
Message-ID: <20150320122040.GA31606@kroah.com> (raw)
In-Reply-To: <20150319125859.GA27166@akanksha>

On Thu, Mar 19, 2015 at 06:28:59PM +0530, Vatika Harlalka wrote:
> Remove struct typedefs and rename structs accordingly 
> as per kernel code conventions.

You have trailing whitespace in your changelog comments :(

> 
> Signed-off-by: Vatika Harlalka <vatikaharlalka@gmail.com>
> ---
>  drivers/staging/wlan-ng/hfa384x.h     |  78 +++++++--------
>  drivers/staging/wlan-ng/hfa384x_usb.c | 179 +++++++++++++++++-----------------
>  drivers/staging/wlan-ng/prism2mgmt.c  |  20 ++--
>  drivers/staging/wlan-ng/prism2mgmt.h  |   4 +-
>  drivers/staging/wlan-ng/prism2mib.c   |  36 +++----
>  drivers/staging/wlan-ng/prism2sta.c   |  40 ++++----
>  drivers/staging/wlan-ng/prism2usb.c   |   8 +-
>  7 files changed, 183 insertions(+), 182 deletions(-)

Please break this up into a patch series, each one only replacing one
specific typedef.  As it is, it's a bit hard to read this way.

thanks,

greg k-h


      reply	other threads:[~2015-03-20 14:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19 12:58 [PATCH] Staging: wlan-ng: Remove struct typedefs Vatika Harlalka
2015-03-20 12:20 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150320122040.GA31606@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=vatikaharlalka@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.