Re: [Outreachy kernel] [PATCH v3] staging: p80211conv: Replace memcpy with ether_addr_copy

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Mar 18, 2015 at 03:50:07PM +0200, Ioana Ciornei wrote:
> Replace memcpy() with ether_addr_copy() since addresses are __aligned(2).
> The 2 structures are aligned to u16:
> 
> struct p80211_hdr_a3 {
>         __le16 fc;              /* 0    2 */
>         u16 dur;                /* 2    2 */
>         u8 a1[ETH_ALEN];        /* 4    6 */
>         u8 a2[ETH_ALEN];        /* 10   6 */
>         u8 a3[ETH_ALEN];        /* 16   6 */
>         u16 seq;                /* 22   2 */
> } __packed;
> 
> Total size: 24
> 
> struct wlan_ethhdr {
>         u8 daddr[WLAN_ETHADDR_LEN];     /* 0    6 */
>         u8 saddr[WLAN_ETHADDR_LEN];     /* 6    6 */
>         u16 type;                       /* 12   2 */
> } __packed;
> 
> Total size: 14
> 
> Signed-off-by: Ioana Ciornei <ciorneiioana@gmail.com>
> ---
> 
> Changes in v3:
> 	- fixed corrupted patch

Please resend this again, after fixing the obvious build errors with it
:(

ALWAYS test build your patches, to not do so annoys the people you send
them to, as it breaks their workflow, and is a bit rude.

thanks,

greg k-h