From: Greg KH <gregkh@linuxfoundation.org>
To: Cristina Opriceana <cristina.opriceana@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 5/5] Staging: iio: Add kernel-doc for struct hmc5843
Date: Fri, 20 Mar 2015 13:33:17 +0100 [thread overview]
Message-ID: <20150320123317.GA7334@kroah.com> (raw)
In-Reply-To: <f3d3109464d5a23c6314b53ea8e9c00965c108e5.1426790662.git.cristina.opriceana@gmail.com>
On Thu, Mar 19, 2015 at 09:10:18PM +0200, Cristina Opriceana wrote:
> This patch documents the struct hmc5843 specific data following
> this warning:
> "CHECK: struct mutex definition without comment".
>
> Signed-off-by: Cristina Opriceana <cristina.opriceana@gmail.com>
> ---
> drivers/staging/iio/magnetometer/hmc5843.h | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/iio/magnetometer/hmc5843.h b/drivers/staging/iio/magnetometer/hmc5843.h
> index 332a75c..ab729d3 100644
> --- a/drivers/staging/iio/magnetometer/hmc5843.h
> +++ b/drivers/staging/iio/magnetometer/hmc5843.h
> @@ -31,12 +31,20 @@ enum hmc5843_ids {
> HMC5983_ID,
> };
>
> +/**
> + * struct hcm5843_data - device specific data
> + * @dev actual device
Don't you need a ":" after "@dev"? That's the proper kerneldoc format,
this will not properly parse.
thanks,
greg k-h
prev parent reply other threads:[~2015-03-20 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 19:03 [PATCH 0/5] Fix iio/magnetometer style warnings Cristina Opriceana
2015-03-19 19:04 ` [PATCH 1/5] Staging: iio: Simplify NULL pointer condition Cristina Opriceana
2015-03-19 19:06 ` [PATCH 2/5] Staging: iio: Align function parameters to match first row Cristina Opriceana
2015-03-19 19:07 ` [PATCH 3/5] Staging: iio: Remove multiple blank lines Cristina Opriceana
2015-03-19 19:07 ` [PATCH 4/5] Staging: iio: Remove line over 80 characters Cristina Opriceana
2015-03-19 19:10 ` [PATCH 5/5] Staging: iio: Add kernel-doc for struct hmc5843 Cristina Opriceana
2015-03-20 12:33 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320123317.GA7334@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cristina.opriceana@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.