All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Ameen Ali <ameenali023@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.
Date: Fri, 20 Mar 2015 13:48:43 +0100	[thread overview]
Message-ID: <20150320124843.GA26504@kroah.com> (raw)
In-Reply-To: <1424882058-2880-1-git-send-email-ameenali023@gmail.com>

On Wed, Feb 25, 2015 at 06:34:18PM +0200, Ameen Ali wrote:
> else if at line 406 has the same condition as the else if at line 404.
> i chosed 0x5 because it's half 0xb  (just a rate controller)
> Signed-off-by : Ameen Ali <Ameenali023@gmail.com>
> ---
>  drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

How do you know this is correct?

Also, we need a blank line before the signed-off-by line and your
subject should give us a chance to know what driver is being changed, as
well as the subsystem.

Also, where are patches 1/3 and 2/3?

thanks,

greg k-h

  reply	other threads:[~2015-03-20 14:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-25 16:34 [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404 Ameen Ali
2015-03-20 12:48 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-02-24 21:00 Ameen Ali
2015-02-24 22:10 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150320124843.GA26504@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ameenali023@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.