From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Date: Fri, 20 Mar 2015 13:03:29 +0000 Subject: Re: [PATCH RESEND v2 4/5] staging: sm750fb: Fix __iomem pointer types Message-Id: <20150320130329.GA23287@kroah.com> List-Id: References: <1426705493-26615-1-git-send-email-lstoakes@gmail.com> <1426705493-26615-2-git-send-email-lstoakes@gmail.com> In-Reply-To: <1426705493-26615-2-git-send-email-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lorenzo Stoakes Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 07:04:53PM +0000, Lorenzo Stoakes wrote: > This patch annotates pointers as referring to I/O mapped memory where they ought > to be, removes now unnecessary ugly casts, eliminates an incorrect deref on I/O > mapped memory by using iowrite16 instead, and updates the pointer arithmetic > accordingly to take into account that the pointers are now byte-sized. This > fixes the following sparse warnings:- > > drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address space of expression > drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address space of expression > > Signed-off-by: Lorenzo Stoakes > --- > v2: Whitespace fixups > > drivers/staging/sm750fb/sm750_cursor.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) I only see 2 patches in this "series", yet you refer to 5? Please resend the whole series, I dropped your previous ones from my queue. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752424AbbCTOmz (ORCPT ); Fri, 20 Mar 2015 10:42:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:40820 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752346AbbCTOmw (ORCPT ); Fri, 20 Mar 2015 10:42:52 -0400 Date: Fri, 20 Mar 2015 14:03:29 +0100 From: Greg KH To: Lorenzo Stoakes Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND v2 4/5] staging: sm750fb: Fix __iomem pointer types Message-ID: <20150320130329.GA23287@kroah.com> References: <1426705493-26615-1-git-send-email-lstoakes@gmail.com> <1426705493-26615-2-git-send-email-lstoakes@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426705493-26615-2-git-send-email-lstoakes@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 18, 2015 at 07:04:53PM +0000, Lorenzo Stoakes wrote: > This patch annotates pointers as referring to I/O mapped memory where they ought > to be, removes now unnecessary ugly casts, eliminates an incorrect deref on I/O > mapped memory by using iowrite16 instead, and updates the pointer arithmetic > accordingly to take into account that the pointers are now byte-sized. This > fixes the following sparse warnings:- > > drivers/staging/sm750fb/sm750_cursor.c:113:19: warning: cast removes address space of expression > drivers/staging/sm750fb/sm750_cursor.c:204:19: warning: cast removes address space of expression > > Signed-off-by: Lorenzo Stoakes > --- > v2: Whitespace fixups > > drivers/staging/sm750fb/sm750_cursor.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) I only see 2 patches in this "series", yet you refer to 5? Please resend the whole series, I dropped your previous ones from my queue. thanks, greg k-h