From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751761AbbCTNSg (ORCPT ); Fri, 20 Mar 2015 09:18:36 -0400 Received: from mail.kernel.org ([198.145.29.136]:44964 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbbCTNSd (ORCPT ); Fri, 20 Mar 2015 09:18:33 -0400 Date: Fri, 20 Mar 2015 10:18:29 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: mingo@kernel.org, namhyung@kernel.org, lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [PATCH -tip] perf tools: Don't allow empty argument for field-separator. Message-ID: <20150320131829.GC16485@kernel.org> References: <1426820272-23302-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426820272-23302-1-git-send-email-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Mar 20, 2015 at 02:57:52AM +0000, Wang Nan escreveu: > Both 'perf diff' and 'perf mem' have 'field-separator' option, which > causes segfault if passed with empty string. This patch uses previously > introduced 'OPT_STRING_NOEMPTY' option macro to prevent fault. > > Signed-off-by: Wang Nan Thanks, applied. - Arnaldo