From: Al Viro <viro@ZenIV.linux.org.uk>
To: Vitaly Chernooky <vitalii.chernookyi@globallogic.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"David Vrabel" <david.vrabel@citrix.com>,
"Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>,
"Iurii Konovalenko" <iurii.konovalenko@globallogic.com>,
"Ian Campbell" <ian.campbell@citrix.com>,
"Boris Ostrovsky" <boris.ostrovsky@oracle.com>,
"Andrii Anisov" <andrii.anisov@globallogic.com>,
"Artem Mygaiev" <artem.mygaiev@globallogic.com>
Subject: Re: [PATCH] [RFC] Fix deadlock on regular nonseekable files
Date: Fri, 20 Mar 2015 13:42:32 +0000 [thread overview]
Message-ID: <20150320134232.GX29656@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CANZZXhCCUh12_1gt0ppc4cMMR-BUsq4rySqNihsEJziOGYbh3A@mail.gmail.com>
On Fri, Mar 20, 2015 at 03:17:54PM +0200, Vitaly Chernooky wrote:
> >From 8ef72cde695d1b1a3e9f6165477c9e7415fca2b1 Mon Sep 17 00:00:00 2001
> From: Vitaly Chernooky <vitaly.chernooky@globallogic.com>
> Date: Fri, 20 Mar 2015 12:26:37 +0200
> Subject: [PATCH] Fix deadlock on regular nonseekable files
>
> 'Commit 9c225f2655e36a470c4f58dbbc99244c5fc7f2d4 ("vfs: atomic f_pos
> accesses as per POSIX")' introduce following regression. If some program
> does multithreaded IO on file in pseudo-filesystem, like procfs, with
> nonseekable files marked as regular, we get deadlock on f_pos_lock
> mutex, if there are simultaneous reading and writing by different
> threads.
Details of deadlock, please. How do we manage that when it's always the
outermost lock to be taken? Describe the minimal deadlocked set of threads -
thread 1 holds <this> and is blocked trying to get <that>, etc.
AFAICS, any threads blocked on f_pos_lock are not holding anything else and
cannot impede the rest. What am I missing here?
next prev parent reply other threads:[~2015-03-20 13:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 13:17 [PATCH] [RFC] Fix deadlock on regular nonseekable files Vitaly Chernooky
2015-03-20 13:42 ` Al Viro [this message]
2015-03-20 14:22 ` Vitaly Chernooky
2015-03-20 14:22 ` Vitaly Chernooky
2015-03-20 14:46 ` Al Viro
2015-03-20 17:37 ` Vitaly Chernooky
2015-03-20 17:55 ` Al Viro
2015-03-20 19:00 ` Marek Marczykowski-Górecki
2015-03-20 19:35 ` Al Viro
2015-03-20 19:35 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320134232.GX29656@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=andrii.anisov@globallogic.com \
--cc=artem.mygaiev@globallogic.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=iurii.konovalenko@globallogic.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marmarek@invisiblethingslab.com \
--cc=torvalds@linux-foundation.org \
--cc=vitalii.chernookyi@globallogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.