All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: use bitmap_weight()
Date: Fri, 20 Mar 2015 16:14:50 +0100	[thread overview]
Message-ID: <20150320151450.GG3556@soda.linbit> (raw)
In-Reply-To: <1426295577-10836-4-git-send-email-akinobu.mita@gmail.com>

On Sat, Mar 14, 2015 at 10:12:56AM +0900, Akinobu Mita wrote:
> Use bitmap_weight to count the total number of bits set in bitmap.
> This change just simplifies the code a bit.

"Simplifies", not sure about that, but ok, maybe.

For the "bm_set_full_words_within_one_page", I disagree.
I think it is more cpu cache friendly to hweight_long then set to ~0UL
each word in turn, than to first bitmap_weight() all words, then
bitmap_fill() all words.

Thanks,

	Lars Ellenberg

BTW, you swapped names and email addresses of phil and me.  Are those
listed incorrectly somewhere, or was that just a mishap on your part?

  reply	other threads:[~2015-03-20 15:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-14  1:12 [PATCH] hpsa: cleanup bitops usage Akinobu Mita
2015-03-14  1:12 ` [PATCH] cpqarray: simplify bitops usages Akinobu Mita
2015-03-14  1:12 ` [PATCH] pktcdvd: convert char array to bitmap Akinobu Mita
2015-03-14  1:12 ` [Drbd-dev] [PATCH] drbd: use bitmap_weight() Akinobu Mita
2015-03-14  1:12   ` Akinobu Mita
2015-03-20 15:14   ` Lars Ellenberg [this message]
2015-03-22  2:11     ` [Drbd-dev] " Akinobu Mita
2015-03-14  1:12 ` [PATCH] ia64: Use bitmap_weight Akinobu Mita
2015-03-14  1:12   ` Akinobu Mita
  -- strict thread matches above, loose matches on Subject: below --
2015-03-22  7:31 [Drbd-dev] [PATCH] drbd: use bitmap_weight() Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150320151450.GG3556@soda.linbit \
    --to=lars.ellenberg@linbit.com \
    --cc=akinobu.mita@gmail.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.