From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbbCTPsk (ORCPT ); Fri, 20 Mar 2015 11:48:40 -0400 Received: from mail.kernel.org ([198.145.29.136]:55133 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752578AbbCTPsj (ORCPT ); Fri, 20 Mar 2015 11:48:39 -0400 Date: Fri, 20 Mar 2015 12:48:35 -0300 From: Arnaldo Carvalho de Melo To: Yunlong Song Cc: a.p.zijlstra@chello.nl, paulus@samba.org, Ingo Molnar , linux-kernel@vger.kernel.org, wangnan0@huawei.com Subject: Re: [PATCH] perf annotate: Fix the segmentation fault bug of perf annotate Message-ID: <20150320154835.GK16485@kernel.org> References: <1426859534-27511-1-git-send-email-yunlong.song@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426859534-27511-1-git-send-email-yunlong.song@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Mar 20, 2015 at 09:52:14PM +0800, Yunlong Song escreveu: > There is a segmentation fault bug in 'perf annotate' using the perf.data > created by 'perf record -g', so fix it. > +++ b/tools/perf/util/annotate.c > @@ -30,6 +30,9 @@ static int disasm_line__parse(char *line, char **namep, char **rawp); > > static void ins__delete(struct ins_operands *ops) > { > + if (ops == NULL) > + return; > + https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/tools/perf/util/annotate.c#n31 https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/tools/perf?id=3995614d9b0320e10ce202836c8477e1bcf1a2d4 I.e. already upstream, it just needs to be merged with perf/core, either Ingo or myself will do that soon, - Arnaldo