From: Mark Rutland <mark.rutland@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 04/28] armv8/ls2085a: Fix generic timer clock source
Date: Fri, 20 Mar 2015 18:29:00 +0000 [thread overview]
Message-ID: <20150320182859.GB24455@leverpostej> (raw)
In-Reply-To: <1426875211-6072-1-git-send-email-yorksun@freescale.com>
> diff --git a/arch/arm/cpu/armv8/fsl-lsch3/mp.c b/arch/arm/cpu/armv8/fsl-lsch3/mp.c
> index ce9c0c1..5338fe6 100644
> --- a/arch/arm/cpu/armv8/fsl-lsch3/mp.c
> +++ b/arch/arm/cpu/armv8/fsl-lsch3/mp.c
> @@ -30,6 +30,13 @@ int fsl_lsch3_wake_seconday_cores(void)
> u32 cores, cpu_up_mask = 1;
> int i, timeout = 10;
> u64 *table = get_spin_tbl_addr();
> +#ifdef COUNTER_FREQUENCY_REAL
> + unsigned long cntfrq = COUNTER_FREQUENCY_REAL;
> +
> + __real_cntfrq = cntfrq; /* update for secondary cores */
Do you need the temporary cntfrq variable? Can't you just have:
__real_cntfrq = COUNTER_FREQUENCY_REAL;
> + flush_dcache_range((unsigned long)&__real_cntfrq,
> + (unsigned long)&__real_cntfrq + 8);
This looks fine, as does the rest of the patch.
So either way:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
next prev parent reply other threads:[~2015-03-20 18:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 18:13 [U-Boot] [PATCH v3 04/28] armv8/ls2085a: Fix generic timer clock source York Sun
2015-03-20 18:29 ` Mark Rutland [this message]
2015-03-20 19:04 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320182859.GB24455@leverpostej \
--to=mark.rutland@arm.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.