From: "J. Bruce Fields" <bfields@fieldses.org>
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: Anna.Schumaker@netapp.com,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFSD: Use correct reply size calculating function
Date: Fri, 20 Mar 2015 16:24:53 -0400 [thread overview]
Message-ID: <20150320202453.GC5955@fieldses.org> (raw)
In-Reply-To: <5505A6AF.7040608@gmail.com>
On Sun, Mar 15, 2015 at 11:35:11PM +0800, Kinglong Mee wrote:
> ALLOCATE/DEALLOCATE only reply one status value to client,
> so, using nfsd4_only_status_rsize for reply size calculating.
Thanks! Applying for 4.1. (It's a bug, but I don't see an obvious
serious impact, so I'm assuming it doesn't need to go to 4.0 and stable.
Tell me if I've overlooked something.)
--b.
>
> Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
> ---
> fs/nfsd/nfs4proc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index 92b9d97..4449359 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -2282,13 +2282,13 @@ static struct nfsd4_operation nfsd4_ops[] = {
> .op_func = (nfsd4op_func)nfsd4_allocate,
> .op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
> .op_name = "OP_ALLOCATE",
> - .op_rsize_bop = (nfsd4op_rsize)nfsd4_write_rsize,
> + .op_rsize_bop = (nfsd4op_rsize)nfsd4_only_status_rsize,
> },
> [OP_DEALLOCATE] = {
> .op_func = (nfsd4op_func)nfsd4_deallocate,
> .op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
> .op_name = "OP_DEALLOCATE",
> - .op_rsize_bop = (nfsd4op_rsize)nfsd4_write_rsize,
> + .op_rsize_bop = (nfsd4op_rsize)nfsd4_only_status_rsize,
> },
> [OP_SEEK] = {
> .op_func = (nfsd4op_func)nfsd4_seek,
> --
> 2.3.1
prev parent reply other threads:[~2015-03-20 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 15:35 [PATCH] NFSD: Use correct reply size calculating function Kinglong Mee
2015-03-16 15:03 ` Anna Schumaker
2015-03-20 20:24 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320202453.GC5955@fieldses.org \
--to=bfields@fieldses.org \
--cc=Anna.Schumaker@netapp.com \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.