From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 3/3] linux: install dtc only in case package host dtc is not selected
Date: Fri, 20 Mar 2015 23:07:00 +0100 [thread overview]
Message-ID: <20150320220700.GB3979@free.fr> (raw)
In-Reply-To: <1421793790-32237-3-git-send-email-ps.report@gmx.net>
Peter, All,
Sorry for the delay...
On 2015-01-20 23:43 +0100, Peter Seiderer spake thusly:
> Suggested by Matthew Weber (see [1]) to avoid double installation
> of host dtc.
>
> [1] http://lists.busybox.net/pipermail/buildroot/2015-January/117121.html
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> linux/linux.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 29f59e8..d598b44 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -292,13 +292,14 @@ endef
> endif
>
>
> +ifeq ($BR2_PACKAGE_HOST_DTC,)
We usually put variables between parenthesis:
ifeq ($(BR2_PACKAGE_HOST_DTC),)
Also, this should have been squashed into the first patch.
Otherwise, looks good:
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> define LINUX_INSTALL_HOST_TOOLS
> # Installing dtc (device tree compiler) as host tool, if selected
> if grep -q "CONFIG_DTC=y" $(@D)/.config; then \
> $(INSTALL) -D -m 0755 $(@D)/scripts/dtc/dtc $(HOST_DIR)/usr/bin/dtc ; \
> fi
> endef
> -
> +endif
>
> define LINUX_INSTALL_IMAGES_CMDS
> cp $(LINUX_IMAGE_PATH) $(BINARIES_DIR)
> --
> 2.1.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-03-20 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 22:43 [Buildroot] [PATCH v4 1/3] dtc: add host build Peter Seiderer
2015-01-20 22:43 ` [Buildroot] [PATCH v4 2/3] dtc: add patches for raspberry pi overlay support Peter Seiderer
2015-03-20 22:22 ` Yann E. MORIN
2015-01-20 22:43 ` [Buildroot] [PATCH v4 3/3] linux: install dtc only in case package host dtc is not selected Peter Seiderer
2015-03-20 22:07 ` Yann E. MORIN [this message]
2015-03-20 22:22 ` [Buildroot] [PATCH v4 1/3] dtc: add host build Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320220700.GB3979@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.