From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] pulseview: new package
Date: Fri, 20 Mar 2015 23:07:52 +0100 [thread overview]
Message-ID: <20150320230752.46792018@free-electrons.com> (raw)
In-Reply-To: <1426759708-4920-1-git-send-email-bgolaszewski@baylibre.com>
Dear Bartosz Golaszewski,
On Thu, 19 Mar 2015 11:08:28 +0100, Bartosz Golaszewski wrote:
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> ---
> Version 2:
> - select BR2_PACKAGE_QT5BASE_PNG in Config.in - this is needed for
> pulseview to properly display .png icons
> - don't select libserial port
Thanks, applied, after fixing a small number of remaining issues:
[Thomas:
- Fix dependency on C++, it should use BR2_INSTALL_LIBSTDCPP and not
BR2_TOOLCHAIN_BUILDROOT_CXX.
- Fix comment dependency, there should be an || between all the
toolchain dependencies. Also fix the dependency on Qt5 for the
comment, which was in the wrong way: the comment was displayed
only when Qt5 was disabled.
- Use -DDISABLE_WERROR=TRUE instead of -DDISABLE_WERROR=y, since
TRUE/FALSE are normally the accepted values for CMake options.]
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-03-20 22:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-19 10:08 [Buildroot] [PATCH v2] pulseview: new package Bartosz Golaszewski
2015-03-20 22:07 ` Thomas Petazzoni [this message]
2015-03-23 22:09 ` Bartosz Golaszewski
2015-04-06 21:43 ` Thomas Petazzoni
2015-04-08 10:45 ` Bartosz Golaszewski
2015-04-08 14:07 ` Bartosz Golaszewski
2015-04-08 14:29 ` Thomas Petazzoni
2015-04-08 14:38 ` Bartosz Golaszewski
2015-04-08 16:05 ` Bartosz Golaszewski
2015-04-08 19:12 ` Thomas Petazzoni
2015-04-08 20:29 ` Bartosz Golaszewski
2015-04-08 20:38 ` Thomas Petazzoni
2015-04-09 10:19 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150320230752.46792018@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.