From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path:
Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152])
by arago-project.org (Postfix) with ESMTPS id A5576529F8
for ;
Fri, 20 Mar 2015 23:38:11 +0000 (UTC)
Received: from dflxv15.itg.ti.com ([128.247.5.124])
by comal.ext.ti.com (8.13.7/8.13.7) with ESMTP id t2KNc8QQ006327
for ; Fri, 20 Mar 2015 18:38:08 -0500
Received: from DLEE70.ent.ti.com (dlemailx.itg.ti.com [157.170.170.113])
by dflxv15.itg.ti.com (8.14.3/8.13.8) with ESMTP id t2KNc7DQ000413
for ; Fri, 20 Mar 2015 18:38:07 -0500
Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE70.ent.ti.com
(157.170.170.113) with Microsoft SMTP Server id 14.3.224.2;
Fri, 20 Mar 2015 18:38:06 -0500
Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by
dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id t2KNc6hd021346;
Fri, 20 Mar 2015 18:38:06 -0500
Date: Fri, 20 Mar 2015 19:38:06 -0400
From: Denys Dmytriyenko
To: Jacob Stiffler
Message-ID: <20150320233805.GQ11557@edge>
References: <1426601937-11416-1-git-send-email-j-stiffler@ti.com>
MIME-Version: 1.0
In-Reply-To: <1426601937-11416-1-git-send-email-j-stiffler@ti.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH] tisdk-image: Generate software manifest text file.
X-BeenThere: meta-arago@arago-project.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
X-List-Received-Date: Fri, 20 Mar 2015 23:38:17 -0000
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Jake,
This looks mostly good. First - do you plan on removing old table headers
replaced with a function call, that you just commented out?
Second - see inline.
On Tue, Mar 17, 2015 at 10:18:57AM -0400, Jacob Stiffler wrote:
> * The generated text file adheres to the SRAS software manifest format.
>
> Signed-off-by: Jacob Stiffler
> ---
> meta-arago-distro/classes/tisdk-image.bbclass | 243 +++++++++++++++++++++----
> 1 file changed, 208 insertions(+), 35 deletions(-)
>
> diff --git a/meta-arago-distro/classes/tisdk-image.bbclass b/meta-arago-distro/classes/tisdk-image.bbclass
> index 747670f..9498f6c 100644
> --- a/meta-arago-distro/classes/tisdk-image.bbclass
> +++ b/meta-arago-distro/classes/tisdk-image.bbclass
> @@ -57,6 +57,7 @@ DEPLOY_SPL_UART_NAME ?= "u-boot-spl.bin-${MACHINE}"
> # This manifest follows the TI manifest format requirements which is why
> # it differs from some of the default manifest code in oe-core.
> SW_MANIFEST_FILE ?= "${IMAGE_ROOTFS}/docs/software_manifest.htm"
> +SW_MANIFEST_TEXT ?= "${IMAGE_ROOTFS}/docs/software_manifest.txt"
>
> # helper function for generating a set of strings based on a list. Taken
> # from the image.bbclass.
> @@ -145,21 +146,17 @@ Any use of ECCNs listed in the Manifest is at the user's risk and without recour
>
> Links in the Manifest
>
> -Any links appearing on this Manifest (for example in the “Obtained from&rdquo field) were verified at the time the Manifest was created. TI makes no guarantee that any listed links will remain active in the future.
> +Any links appearing on this Manifest (for example in the “Obtained from” field) were verified at the time the Manifest was created. TI makes no guarantee that any listed links will remain active in the future.
>
>
> Open Source License References
>
> -Your company is responsible for confirming the applicable license terms for any open source Software listed in this Manifest that was not “Obtained from&rdquo TI. Any open source license specified in this Manifest for Sotware that was not “Obtained from&rdquo TI is for TI's internal use only and shall not be construed as a representation of warranty regarding the proper open source license terms for such Software.
> +Your company is responsible for confirming the applicable license terms for any open source Software listed in this Manifest that was not “Obtained from” TI. Any open source license specified in this Manifest for Sotware that was not “Obtained from” TI is for TI's internal use only and shall not be construed as a representation of warranty regarding the proper open source license terms for such Software.
>
>
> Export Information
>
> -ECCN for Software included in this release: 5D002 License Exception TSU
> -
> -
> -
> -ECCN for Technology (e.g., user documentation, specifications) included in this release: 5D002 License Exception TSU
> +ECCN for Software included in this release: 5D991 (Telecom Software)
Can you please elaborate on this ECCN change?
>
>
> Manifest
> @@ -167,6 +164,62 @@ ECCN for Technology (e.g., user documentation, specifications) included in this
> See Legend above for a description of the columns and possible values.
>
> " > ${SW_MANIFEST_FILE}
> +
> +cat > ${SW_MANIFEST_TEXT} << 'EOF'
> +<--
> +Manifest template 1.0
> +
> +This template is used to generate an unloadable manifest to the SRAS. To do so, save the document as a plain text file (Save As .txt). Do not change any options on the save which means leave the default as Windows Default Encoding. The SRAS will generate a nice looking HTML manifest for you.
Is it unloadable or uploadable here ^^^^^^^^^^^^^?
And the rest below is just headers and footers - see the questions at the
beginning.
> +
> +Instructions:
> +
> + 1. Text in blue should not be edited or removed. It will NOT appear on your manifest.
> + 2. DO NOT color outside the lines in the manifest. There are specific blocks where you enter information. Information
> + should only be entered in the sections below and not outside of them.
> + 3. DO NOT use the < or > symbols in your manifest table or in your footnotes.
> + 4. Please REFRAIN from using Word specific formatting when filling in the table. Examples are things like superscripts,
> + subscripts, etc. We are unable to understand those.
> + 5. Auto correction is not your friend in word. Please turn it off. It should be disabled already in this template.
> +
> +Table Instructions:
> +
> +Define what you are delivering by filling in the table below. Tables start with the start keyword end with the end keyword,
and may also contain footnotes specific to that table.
> +
> +You can have as many .Public. tables as you like in your manifest and can name them. You can have one and only one .Private. table. To create additional tables copy everything starting with and then paste it after the table below.
> +
> +The field .attribute =. can be set to Public (the default) or Private to define the type of table it is. If the table is Public then everything in the table will appear on your manifest. If the table is Private then none of the entries will appear on your manifest but they will be stored in the SRAS. Private tables are useful for documenting third party code, that requires Legal review, but does not need to be acknowledged on the manifest you ship; e.g. it may be covered by our TI license.
> +
> +The field .name = . is used to put a heading over the table on the manifest you ship.
> +
> +The field .description =. is used to put a description under the Table name on the manifest you ship.
> +
> +To learn how to document software in the table read the instructions here. A brief explanation of the table columns follows.
> +License Type - If its an SPDX defined license use their short name identifier. You can see a list here: http://spdx.org/licenses/ . If it.s not on the list and not a commercial or TSPA license then use the application name as the license.
> +
> +Delivered As - This field will either be .Source., .Binary. or .Source and Binary. and is the form the content of the Software is delivered in. If the Software is delivered in an archive format, this field applies to the contents of the archive. If the word Limited is used with Source, as in .Limited Source. or .Limited Source and Binary. then only portions of the Source for the application are provided.
> +
> +Modified by TI - This field will either be .Yes. or .No.. A .Yes. means TI has made changes to the Software. A .No. means TI has not made any changes. Note: This field is not applicable for Software .Obtained from. TI.
> +
> +Location - The directory name and path on the media, e.g. drive, (or in an archive) where the Software is located after installing or extracting.
> +
> +Obtained From - This field specifies from where or from whom TI obtained the Software. It may be a URL to an Open Source site, a 3rd party licensor, or TI (if TI developed the software). If this field contains a link to Open Source software, the date TI downloaded the Software is also recorded. See Links Disclaimer in the Disclaimers Section.
> +-->
> +
> +
> +Version = .1.0.
> +Sep = .|.
> +Tool=.Word.
> +
> +
> +<-- ** Do not edit or remove anything above this line **
> +-->
> +
> +<--
> +Instructions: DO NOT Alter the column headings below. This is now a single row table as opposed to the older manifests which used merged rows. The order is extremely important; if you change the order or add or remove a column the upload will not work.
> +-->
> +
> +EOF
> +
> }
>
> sw_manifest_footer() {
> @@ -212,27 +265,107 @@ echo "
>