All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nft_compat: set IP6T_F_PROTO flag if protocol is set
Date: Sat, 21 Mar 2015 20:14:46 +0100	[thread overview]
Message-ID: <20150321191446.GA8344@salvia> (raw)
In-Reply-To: <20150321184509.GB16593@acer.localdomain>

On Sat, Mar 21, 2015 at 06:45:09PM +0000, Patrick McHardy wrote:
> On 21.03, Pablo Neira Ayuso wrote:
> > ip6tables extensions check for this flag to restrict match/target to a
> > given protocol. Without this flag set, SYNPROXY6 returns an error.
> 
> That looks like the correct solution to me, thanks!
>
> I guess we should also fix all the ip6_tables extensions that think
> they're matching on the L4 protocol but are actually not enforcing
> this.

I'll send a follow up patch to fix this. Thanks for reviewing!

      reply	other threads:[~2015-03-21 19:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-21 18:36 [PATCH nf] netfilter: nft_compat: set IP6T_F_PROTO flag if protocol is set Pablo Neira Ayuso
2015-03-21 18:45 ` Patrick McHardy
2015-03-21 19:14   ` Pablo Neira Ayuso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150321191446.GA8344@salvia \
    --to=pablo@netfilter.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.