From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751607AbbCUWHB (ORCPT ); Sat, 21 Mar 2015 18:07:01 -0400 Received: from 200.180.216.87.static.jazztel.es ([87.216.180.200]:34441 "HELO mail.sysvalve.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751314AbbCUWHA (ORCPT ); Sat, 21 Mar 2015 18:07:00 -0400 Date: Sat, 21 Mar 2015 23:06:56 +0100 From: =?iso-8859-1?Q?L=2E_Alberto_Gim=E9nez?= To: Richard Weinberger Cc: LKML , Andy Whitcroft , Joe Perches Subject: Re: [PATCH] checkpatch.pl: Add warning for harmful goto labels Message-ID: <20150321220655.GA14583@bart.evergreen.loc> References: <1426972574-12199-1-git-send-email-agimenez@sysvalve.es> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 21, 2015 at 10:40:46PM +0100, Richard Weinberger wrote: > Huh? Since when? There are a lot of cases where a too generic goto label for cleanup causes a bug or makes debugging harder. Last time was this G+ post, by Dan Carpenter: https://plus.google.com/106378716002406849458/posts/DfuAkt8szf2 > rw@azrael:~/linux (for-v4.1/uml_misc $)> git grep -e "goto out;" | wc -l > 26667 > rw@azrael:~/linux (for-v4.1/uml_misc $)> git grep -e "goto fail;" | wc -l > 3733 If something is already in the kernel code, does that mean that it's OK? I honestly don't think so, and I think that goto labels for cleanup exit paths should be a little more descriptive. > What is next? Variable name "i" considered harmful? No one complained about that so far. I might add that to checkpatch.pl if needed. > Can we please stop this nonsense. It's just a proposal for a warning. If it is really not needed, it won't be applied and life will go on :) -- L. Alberto Giménez GnuPG key ID 0xDD4E27AB