From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751730AbbCVMQ5 (ORCPT ); Sun, 22 Mar 2015 08:16:57 -0400 Received: from 200.180.216.87.static.jazztel.es ([87.216.180.200]:55673 "HELO mail.sysvalve.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751632AbbCVMQz (ORCPT ); Sun, 22 Mar 2015 08:16:55 -0400 Date: Sun, 22 Mar 2015 13:16:51 +0100 From: =?iso-8859-1?Q?L=2E_Alberto_Gim=E9nez?= To: Joe Perches Cc: Richard Weinberger , LKML , Andy Whitcroft Subject: Re: [PATCH] checkpatch.pl: Add warning for harmful goto labels Message-ID: <20150322121651.GA15680@bart.evergreen.loc> References: <1426972574-12199-1-git-send-email-agimenez@sysvalve.es> <20150321220655.GA14583@bart.evergreen.loc> <550DECE9.3090801@nod.at> <1426992999.20324.9.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1426992999.20324.9.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 21, 2015 at 07:56:39PM -0700, Joe Perches wrote: > [] > > > If something is already in the kernel code, does that mean that it's OK? > > > I honestly don't think so, and I think that goto labels for cleanup exit > > > paths should be a little more descriptive. > > > > I disagree. out and exit are perfectly fine labels. > > I agree with you Richard. > [...] > > > It's just a proposal for a warning. If it is really not needed, it won't > > > be applied and life will go on :) > > In that case, it'd be nicer to preface the patch subject with RFC Yes, you are right, sorry about that. Thank you for the feedback guys! And Richard, of course I was kidding about the 'i' variable. I enjoy sarcasm myself too :) Best regards, -- L. Alberto Giménez GnuPG key ID 0xDD4E27AB