From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55694)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YZyAC-0005Hj-Lf
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 04:56:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YZyA8-0006PH-LF
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 04:56:48 -0400
Received: from smtp3.mundo-r.com ([212.51.32.191]:35847 helo=smtp4.mundo-r.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berto@igalia.com>) id 1YZyA8-0006GJ-FE
	for qemu-devel@nongnu.org; Mon, 23 Mar 2015 04:56:44 -0400
Date: Mon, 23 Mar 2015 09:56:05 +0100
From: Alberto Garcia <berto@igalia.com>
Message-ID: <20150323085605.GA25603@igalia.com>
References: <1427088255-29885-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1427088255-29885-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block: Switch to host monotonic clock
 for IO throttling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, pbonzini@redhat.com, qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>

On Mon, Mar 23, 2015 at 01:24:15PM +0800, Fam Zheng wrote:
> Currently, throttle timers won't make any progress when VCPU is not
> running, which would stall the request queue in utils, qtest, vm
> suspending, and live migration without special handling.
> 
> For example in bdrv_drain_all, all requests are resumed immediately
> without taking throttling limit into account. This means whenever it is
> called, IO throttling goes ineffective (examples: system reset,
> migration and many block job operations.).
> 
> This might be some loophole that guest could exploit.
> 
> If we use the host clock, we can later just trust the nested poll when
> waiting for requests.
> 
> Note that for qemu-iotests case 093, which sets up qtest when running
> QEMU, we still use vm clock so the script can control the clock stepping
> in order to be deterministic.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>

Reviewed-by: Alberto Garcia <berto@igalia.com>

Berto